Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the transactor's balance covers the Tx #1275

Closed
wants to merge 1 commit into from
Closed

Check if the transactor's balance covers the Tx #1275

wants to merge 1 commit into from

Conversation

gastonponti
Copy link
Contributor

Description

In the DoCall for rpc calls, when it's not estimating, check if the transactors balance can cover the whole transaction

Related issues

Backwards compatibility

yes

@gastonponti
Copy link
Contributor Author

Closing PR to avoid noice. Even if the case is possible, is not relevant enough, and it's going to be changed in the v1.9.13 from upstream.

The issue #810 was making reference of another problem already fixed in the PR #825

@gastonponti gastonponti deleted the gastonponti/fix-balance-gas-check branch December 16, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaj asaj Awaiting requested review from asaj

@timmoreton timmoreton Awaiting requested review from timmoreton

@mcortesi mcortesi Awaiting requested review from mcortesi

@nategraf nategraf Awaiting requested review from nategraf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix transaction failed to buy gas
1 participant
@gastonponti