Update mycelo config values to work with monorepo e2e tests

[oneeman]

Description

This is a companion PR to celo-org/celo-monorepo#8086, with some changes which are needed to make the tests work:

1. Monorepo uses a single validator group, so we update the mycelo monorepo template to do so as well.
2. Make the DowntimeSlasher's slashable downtime small so it works with the small epoch sizes we use (if the slashable downtime is larger than the epoch size, you can't test out slashing)
3. Modify the monorepo template's config values for epoch rewards and initial reserve balance to match what is done in the monorepo for the 'testing' context (which is what the e2e tests use). See https://github.com/celo-org/celo-monorepo/blob/c90edf1c938363e24746c90153d36263bb668aef/packages/protocol/migrationsConfig.js#L244-L281 .

Tested

• Tested in conjunction with the monorepo tests PR above, locally and multiple times in CI. Did not witness flakiness in the e2e tests.

Related issues

• Necessary for Use mycelo for the e2e tests #1384

Backwards compatibility

No incompatibility

[codecov]

Codecov Report

Merging #1579 (e4e034c) into master (46be11f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
- Coverage   54.64%   54.63%   -0.02%     
==========================================
  Files         607      607              
  Lines       69935    69935              
==========================================
- Hits        38213    38206       -7     
- Misses      28296    28309      +13     
+ Partials     3426     3420       -6     

Impacted Files	Coverage Δ
p2p/discover/v4_udp.go	74.57% <0.00%> (-4.24%)	⬇️
les/distributor.go	70.31% <0.00%> (-2.35%)	⬇️
whisper/whisperv6/message.go	66.23% <0.00%> (-1.30%)	⬇️
rpc/handler.go	89.24% <0.00%> (-1.08%)	⬇️
rpc/client.go	79.60% <0.00%> (-0.81%)	⬇️
les/fetcher.go	44.57% <0.00%> (-0.68%)	⬇️
eth/fetcher/block_fetcher.go	82.90% <0.00%> (-0.65%)	⬇️
p2p/simulations/http.go	66.66% <0.00%> (-0.65%)	⬇️
eth/downloader/downloader.go	74.76% <0.00%> (-0.21%)	⬇️
trie/proof.go	75.40% <0.00%> (ø)
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46be11f...e4e034c. Read the comment docs.

[oneeman]

Why and who approved it the changes ?? Why are you changing ?? Do not change it

@alice-dfi Could you elaborate on your concern? Mycelo is a tool to facilitate development and testing. It it used to generate genesis files for new ephemeral testnets. The changes in this PR modify two things:

1. The default slashable downtime value, because the previous one doesn't make sense given the default epoch size
2. Settings for mycelo's 'monorepo' template to make it match more closely the configuration used in celo-monorepo (which is the reason that template exists)

These changes only affect the generation of new genesis files from scratch using mycelo. They do not affect existing networks nor even the generation of a genesis file from an existing mycelo directory with a genesis config. Plus, the genesis config as a whole can be customized by the user to suit their needs. So if you have any concerns about this, please provide more details.

[mcortesi]

looks good, left one comment

[mcortesi]

is this desirable for every network template or only for monorepo one?

[oneeman]

I think so. The default epoch size (i.e. the epoch size of the default template) is 10, so the former slashable downtime of 60 doesn't make sense with that.

The only template that has a different epoch size is the load test (1000). If we wanted to avoid slashable downtime of 4 with epoch size 1000 it would make sense to override it on the loadtest template rather than have 60 be the default. But the low slashable downtime makes no difference if nobody does the slashing, so I don't see it as mattering for the load test template anyway.