CI: specify a monorepo commit rather than a branch #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use commit from current master.
oneeman
force-pushed
the
oneeman/e2e-tests-force-mycelo
branch
from
d077fc4 to
7e5794d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a companion PR to celo-org/celo-monorepo#8291.
The environment variable
E2E_TESTS_FORCE_USE_MYCELOwill be set in the CircleCI project config, so we don't need to set it in the CircleCI yaml config. But we do want to stop always checking out the monorepo master branch. This PR will set a fixed commit from master instead, and changes the CI config to work with a commit hash or branch rather than only with a branch. It also sets the monorepo commit to the current commit on monorepo's master (so that the commit used won't change by itself every time a PR is merged to monorepo master).Alternatively, we could consolidate this with
system-contracts-monorepo-versionto have only a single branch/commit used for both the monorepo e2e tests and for building the contracts for the e2e system in celo-blockchain.Tested
Will check on CI that tests pass and that they use mycelo as desired.