Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RPC API compatibility for Ethers.js #1957

Merged
merged 31 commits into from
Sep 27, 2022

Commits on Sep 9, 2022

  1. Add minimal ts project

    piersy committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    9e3fc5d View commit details
    Browse the repository at this point in the history
  2. Add ethers.js dependency

    piersy committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    9ebdd19 View commit details
    Browse the repository at this point in the history
  3. Add etherejs api test (currently failing)

    Test tries to get the block
    piersy committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    11fa86e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    70232a0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    33de2a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Configuration menu
    Copy the full SHA
    8e2c1c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aec0159 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Use framework for ethers.js compatibility tests

    Instead of running a script we now use the mocha testing framework which
    provides much better output and makes it much easier to add testcases.
    piersy committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    84bd94c View commit details
    Browse the repository at this point in the history
  2. Store package lock

    piersy committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c624df4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d175c1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cb1479c View commit details
    Browse the repository at this point in the history
  5. Add dockerfile for a node/golang CI executor

    Update CI to use new docker image, since we now need to run node and npm
    as part of our tests.
    piersy committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    bd71fd1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9895733 View commit details
    Browse the repository at this point in the history
  7. Add debug

    piersy committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    45e386b View commit details
    Browse the repository at this point in the history
  8. Add more debug

    piersy committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    dd17619 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2022

  1. Change address format

    The IPV6 addresses returned from the geth node were not working on CI so
    we convert them to IPV4 addresses.
    piersy committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    a0174f4 View commit details
    Browse the repository at this point in the history
  2. Update log message for clarity

    piersy committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    2bdc31e View commit details
    Browse the repository at this point in the history
  3. Update node-golang dockerfile

    Add installed go binaries location to user's path
    piersy committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    b354bc4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ccd6e59 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Update readme to specify a minimum go version

    This should mitigate the readme going out of date whenever we update go.
    piersy committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    5fd28ff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e4e0216 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    80d55aa View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Flag to disable RPC compatibilty fields

    If the flag is set then the 'gasLimit' and 'baseFeePerGas' fields will
    not be returned on RPC blocks.
    piersy committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    0195bec View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Configuration menu
    Copy the full SHA
    16dc1a7 View commit details
    Browse the repository at this point in the history
  2. Split the tests under 2 describe headings

    One for tests with state one for tests without.
    
    This makes executing each batch of tests easier because we can just grep
    for the describe headings.
    piersy committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    99b9750 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0fa5309 View commit details
    Browse the repository at this point in the history
  4. Move ethersjs test project under e2e_test

    Just to further signify that it is not for standalone use.
    piersy committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    af4224f View commit details
    Browse the repository at this point in the history
  5. Do not return block fields that cant be retreived

    If the state is missing for gasLimit or baseFeePerGas or if there is
    some other failure when retrieving them then do not add them as fields
    to the block. Preivously in some cases a default value would have been
    added to the block and returned.
    piersy committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    419c504 View commit details
    Browse the repository at this point in the history
  6. Fix typos

    hbandura committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    986b06c View commit details
    Browse the repository at this point in the history
  7. Remove unused code

    hbandura committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    f8dc1ed View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8f3e4f6 View commit details
    Browse the repository at this point in the history