-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transfer prestate trace #2075
Conversation
91ce8e8
to
59600c6
Compare
Coverage from tests in coverage: 48.5% of statements across all listed packagescoverage: 63.1% of statements in consensus/istanbul coverage: 40.1% of statements in consensus/istanbul/announce coverage: 53.1% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.2% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.4% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
- Coverage 54.27% 54.26% -0.01%
==========================================
Files 692 692
Lines 115642 115642
==========================================
- Hits 62761 62757 -4
- Misses 49044 49056 +12
+ Partials 3837 3829 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Running the pretracer on a simple celo transfer failed with an exception in the js pretracer.
This happened, because in that case the result wasn't properly initialized.
This problem has been fixed upstream in ethereum/go-ethereum#24268. As that PR also includes the addition of the native prestate tracer, I just applied the fix and left other changes for a later merge.
I also added a testcase for a simple transfer to prevent regressions.
Issues
Fixes #2066