Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force failure if there is any unit test failed #2113

Merged
merged 3 commits into from
May 22, 2023

Conversation

jcortejoso
Copy link
Member

Description

Force to fail the CI job if there is any failed unit test

@jcortejoso jcortejoso force-pushed the jcortejoso/force-fail-unit-tests branch from faf0c65 to cfd14b6 Compare May 19, 2023 09:13
@github-actions
Copy link

github-actions bot commented May 19, 2023

Coverage from tests in ./e2e_test/... for ./consensus/istanbul/... at commit 6a7c41f

coverage: 50.6% of statements across all listed packages
coverage:  63.2% of statements in consensus/istanbul
coverage:  42.7% of statements in consensus/istanbul/announce
coverage:  55.7% of statements in consensus/istanbul/backend
coverage:   0.0% of statements in consensus/istanbul/backend/backendtest
coverage:  24.3% of statements in consensus/istanbul/backend/internal/replica
coverage:  64.7% of statements in consensus/istanbul/core
coverage:  50.0% of statements in consensus/istanbul/db
coverage:   0.0% of statements in consensus/istanbul/proxy
coverage:  64.4% of statements in consensus/istanbul/uptime
coverage:  51.8% of statements in consensus/istanbul/validator
coverage:  79.2% of statements in consensus/istanbul/validator/random

@github-actions
Copy link

github-actions bot commented May 19, 2023

5813 passed, 44 skipped

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 69.50% and project coverage change: +1.03 🎉

Comparison is base (71bdbcf) 54.30% compared to head (08f08a8) 55.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2113      +/-   ##
==========================================
+ Coverage   54.30%   55.33%   +1.03%     
==========================================
  Files         692      674      -18     
  Lines      115642   113414    -2228     
==========================================
- Hits        62795    62762      -33     
+ Misses      49014    46843    -2171     
+ Partials     3833     3809      -24     
Impacted Files Coverage Δ
cmd/devp2p/internal/ethtest/transaction.go 0.00% <0.00%> (ø)
cmd/geth/chaincmd.go 0.00% <0.00%> (ø)
cmd/geth/main.go 21.39% <ø> (+0.91%) ⬆️
cmd/geth/usage.go 10.90% <ø> (ø)
cmd/utils/flags.go 2.56% <0.00%> (ø)
consensus/istanbul/utils.go 47.10% <ø> (+1.13%) ⬆️
contracts/currency/currency.go 55.00% <ø> (ø)
contracts/election/election.go 25.00% <ø> (ø)
contracts/epoch_rewards/epoch_rewards.go 88.88% <ø> (ø)
contracts/freezer/freezer.go 70.00% <ø> (ø)
... and 42 more

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gastonponti gastonponti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gastonponti gastonponti merged commit 21d8283 into master May 22, 2023
@gastonponti gastonponti deleted the jcortejoso/force-fail-unit-tests branch May 22, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants