Hardcode pre gingerbread block gas limits for existing chains #2 #2229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 50.6% of statements across all listed packagescoverage: 63.4% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.8% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 64.2% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2229 +/- ##
==========================================
- Coverage 55.06% 55.05% -0.01%
==========================================
Files 683 684 +1
Lines 114577 114596 +19
==========================================
Hits 63095 63095
- Misses 47578 47606 +28
+ Partials 3904 3895 -9 ☔ View full report in Codecov by Sentry. |
karlb
approved these changes
Jan 26, 2024
hbandura
force-pushed
the
piersy/hardcode_gas_limits
branch
from
d033231
to
e09a6d3
Compare
piersy
force-pushed
the
piersy/hardcode_gas_limits
branch
2 times, most recently
from
fdbd2a0
to
9fb2e7d
Compare
Also reduce nesting in GetBlockXXXX methods.
ChainID is allowed to be unset.
piersy
force-pushed
the
piersy/hardcode_gas_limits
branch
from
9fb2e7d
to
790f80e
Compare
piersy
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this duplicates #2216 because we force reverted master after #2216 was merged.
Description
Ensures that for mainnet, alfajores and baklava, nodes will return the correct block gas limit up to the gingerbread fork even if they are not archive nodes when running in eth compatibility mode (I.E.
--disablerpcethcompatibilityis not set). More detail can be found here:Other changes
A small re-factor of GetBlockByNumber and GetBlockByHash to reduce the depth of nesting.
Tested
CI is passing
Related issues
Backwards compatibility
This change is not backwards compatible with the previous implementations on mainnet, alfajores or baklava which would have returned a zero gas limit for a block if there was no state for that block.