Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain Q and F #803

Merged
merged 3 commits into from
Jan 13, 2020
Merged

Explain Q and F #803

merged 3 commits into from
Jan 13, 2020

Conversation

timmoreton
Copy link
Contributor

Description

Add a comment to explain MinQuorumSize and F.

Backwards compatibility

Yes

@timmoreton timmoreton requested a review from asaj as a code owner January 9, 2020 22:43
nategraf
nategraf approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful!

consensus/istanbul/validator/default.go Outdated Show resolved Hide resolved
consensus/istanbul/validator/default.go Outdated Show resolved Hide resolved
@nategraf nategraf assigned timmoreton and unassigned nategraf Jan 9, 2020
@asaj asaj removed their assignment Jan 9, 2020
@timmoreton timmoreton assigned nategraf and unassigned timmoreton Jan 10, 2020
@nategraf nategraf assigned timmoreton and unassigned nategraf Jan 10, 2020
@timmoreton timmoreton merged commit f86d673 into master Jan 13, 2020
@timmoreton timmoreton deleted the timmoreton/quorum-explain branch January 13, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nategraf nategraf nategraf approved these changes

@asaj asaj Awaiting requested review from asaj

Assignees

@timmoreton timmoreton

@trianglesphere trianglesphere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timmoreton @nategraf @asaj @trianglesphere