Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS app should use appropriate bundle identifiers for each supported env #1156

Closed
jeanregisser opened this issue Oct 1, 2019 · 0 comments · Fixed by #3140
Closed

iOS app should use appropriate bundle identifiers for each supported env #1156

jeanregisser opened this issue Oct 1, 2019 · 0 comments · Fixed by #3140
Labels
ios Priority: P2 Major tech-debt triaged label for issues that have been assigned a priority wallet

Comments

@jeanregisser
Copy link
Contributor

Expected Behavior

It should use appropriate bundle identifiers for each supported env.
Probably using an Xcode scheme for each of them. See https://github.com/luggit/react-native-config#ios-1

Current Behavior

It uses the same bundle identifier not matter what env is active.
@nityas nityas added applications bug Something isn't working tech-debt and removed bug Something isn't working labels Oct 14, 2019
@jeanregisser jeanregisser mentioned this issue Oct 15, 2019
Merged
@cmcewen cmcewen added Priority: P2 Major triaged label for issues that have been assigned a priority labels Oct 23, 2019
jeanregisser added a commit that referenced this issue Mar 17, 2020
@jeanregisser
Support multiple env file in Xcode
b85c2b9 
Idea is one env file per scheme
Addresses #1156
jeanregisser added a commit that referenced this issue Mar 18, 2020
@jeanregisser
Support multiple env file in Xcode
8fd1595 
Idea is one env file per scheme
Addresses #1156
@jeanregisser jeanregisser mentioned this issue Mar 18, 2020
Merged
jeanregisser added a commit that referenced this issue Mar 19, 2020
@jeanregisser
[Wallet] iOS multi env support + fastlane deployments (#3140)
875df2d 
* Support multiple env file in Xcode

Idea is one env file per scheme
Addresses #1156

* Fix run_app script choking with env vars containing spaces

* Add fastlane lanes for iOS alfajores and pilot

* Fix incorrect link

* Remove unused tvOS scheme

* Fix e2e test

* Rename generated config tmp.xcconfig -> env.xcconfig

* Fix missing google service plist for CI build
lucasege pushed a commit that referenced this issue Mar 19, 2020
@jeanregisser
[Wallet] iOS multi env support + fastlane deployments (#3140)
4eb0357 
* Support multiple env file in Xcode

Idea is one env file per scheme
Addresses #1156

* Fix run_app script choking with env vars containing spaces

* Add fastlane lanes for iOS alfajores and pilot

* Fix incorrect link

* Remove unused tvOS scheme

* Fix e2e test

* Rename generated config tmp.xcconfig -> env.xcconfig

* Fix missing google service plist for CI build
lucasege pushed a commit that referenced this issue Mar 19, 2020
@aslawson @jeanregisser
@cmcewen @aaronmgdr
ReleaseGold CLI (#2981)
df536ca 
* Start of releasegold cli

* Info cli command

* Wip adding many more fns

* Set max distribution fn

* Unifying style and adding set-beneficiary

* Addign withdraw and addressing various bugs introduced in cli deps

* Adding more commands - gold, revoke, and refund

* Adding final commands, still need to verify authorize and address todos. Also adding start_gold to script

* Fxing ts weird bug

* fixing type bug

* Lint

* Switching src to lib

* Fixing cli bugs

* Docs

* Contractkit docs

* WIP

* Adding test framework for releasegold cli commands

* Fixing flaky tests

* Adding transfer

* Fixing tests

* Fixing jest timeout

* lint

* Lint and comments

* wip

* Small adjustments to migrations config (#2972)

* Small adjustments to migrations config

* More adjustments

* updated based on comments

* Fixed migration and testing around frozenGold and initialBalance, added addresses for governance approver, reserve spender, and whitelisted for transfers, changed frozenDays value to be in days rather than seconds

* remove frozenGold since it requires reserve to have a balance greater than it, will require a governance proposal to initialize after the transfer of gold to reserve

* bumped double signing slashing penalty to 9k

* updates based on feedback

* add more gas for e2e transfer tests that delete whitelist array

* few more tweeks to migration config

* fixed variable name MINUTE in config

Co-authored-by: Amy Slawson <amyslawson@MacBook-Pro.local>
Co-authored-by: Amy Slawson <aslawson@users.noreply.github.com>

* [Wallet] Fix splash screen green gap (#3105)

* Fix web build by changing literal to string (#3109)

* Experience Brand kit updates (#3090)

* Reducing boilerplate finished and adding better checks

* Reverting cleanup

* WIP on review

* WIP review

* Updating scripts to add functionality

* Updating script

* Addressign review, still flaky tests

* Lint

* Flaky

* [Wallet] iOS multi env support + fastlane deployments (#3140)

* Support multiple env file in Xcode

Idea is one env file per scheme
Addresses #1156

* Fix run_app script choking with env vars containing spaces

* Add fastlane lanes for iOS alfajores and pilot

* Fix incorrect link

* Remove unused tvOS scheme

* Fix e2e test

* Rename generated config tmp.xcconfig -> env.xcconfig

* Fix missing google service plist for CI build

* Adding one more improvement

* Removing unnecessary changes

* lint

Co-authored-by: Asa Oines <a@celo.org>
Co-authored-by: Amy Slawson <amyslawson@MacBook-Pro.local>
Co-authored-by: Amy Slawson <aslawson@users.noreply.github.com>
Co-authored-by: Jean Regisser <jean.regisser@gmail.com>
Co-authored-by: Connor McEwen <connor.mcewen@gmail.com>
Co-authored-by: Aaron DeRuvo <aaron.deruvo@gmail.com>
@lili2311 lili2311 mentioned this issue Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ios Priority: P2 Major tech-debt triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] iOS multi env support + fastlane deployments celo-org/celo-monorepo
3 participants
@jeanregisser @cmcewen @nityas