Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Error “Bad Connection...” is overlaps on QR code icon when device internet connection is bad. #1286

Closed
Lss-Ankit opened this issue Oct 10, 2019 · 1 comment · Fixed by #1765
Closed

[Android] Error “Bad Connection...” is overlaps on QR code icon when device internet connection is bad. #1286

Lss-Ankit opened this issue Oct 10, 2019 · 1 comment · Fixed by #1765
Assignees
@annakaz
Labels
bug Something isn't working Priority: P2 Major qa quick-fix Things that should be quick fixes- Good for first issues & ramping up triaged label for issues that have been assigned a priority wallet

Comments

@Lss-Ankit
Copy link

Lss-Ankit commented Oct 10, 2019 •
edited
Loading

App version: Play store build v1.5.0
Repro on: Moto E (4.4.4),Samsung Galaxy S4 (5.0), Samsung Galaxy A5 (6.0.1).
Does not repro: Samsung j7 prime (6.0.1), Samsung Galaxy A8+ (8.0.0), Samsung galaxy note 9 (9.0)
Priority: Low
Testing Account: (315) 678-6563/Backup Kay

Repro Steps:

  1. Launch the app.
  2. Turn off the device internet connection and the user is on the Wallet tab.
  3. Make sure Bad connection error message is shown.
  4. Observe.

Current Behavior: Error “Bad Connection...” overlaps on QR code icon
Expected Behavior: Error “Bad Connection...” should not overlaps on QR code icon
Attachment: Android_SmallScreen_BadConnectionErrorOvserlapIssue.png
Android_SmallScreen_BadConnectionErrorOvserlapIssue
@Lss-Ankit Lss-Ankit added bug Something isn't working qa wallet labels Oct 10, 2019
@Lss-Ankit Lss-Ankit changed the title [Android] Error “Bad Connection...” overlaps on QR code icon when device is internet connection is bad. [Android] Error “Bad Connection...” is overlaps on QR code icon when device internet connection is bad. Oct 10, 2019
@nityas nityas added applications quick-fix Things that should be quick fixes- Good for first issues & ramping up Priority: P2 Major triaged label for issues that have been assigned a priority labels Oct 14, 2019
@Lss-Ankit
Copy link
Author

Verified with iOS Test flight build v1.5.0 (10) and observed that issue: Error “Bad Connection...” overlaps on QR code icon when device internet connection is bad.

Attachment: IOS_BadConnectionErrorOverlaps.png
IOS_BadConnectionErrorOverlaps

@annakaz annakaz self-assigned this Nov 16, 2019
@annakaz annakaz mentioned this issue Nov 19, 2019
Merged
@lili2311 lili2311 mentioned this issue Sep 25, 2023
Open
This was referenced Nov 24, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annakaz annakaz

Labels
bug Something isn't working Priority: P2 Major qa quick-fix Things that should be quick fixes- Good for first issues & ramping up triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] Fix disconnecting banner overlap in wallet home celo-org/celo-monorepo
3 participants
@nityas @annakaz @Lss-Ankit