[Wallet] Fix disconnecting banner overlap in wallet home #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1765 +/- ##
==========================================
+ Coverage 74.17% 74.21% +0.03%
==========================================
Files 278 278
Lines 7652 7652
Branches 957 957
==========================================
+ Hits 5676 5679 +3
+ Misses 1858 1856 -2
+ Partials 118 117 -1
Continue to review full report at Codecov.
|
|
The "Connecting to Celo..." is also moved down a little, right? |
jeanregisser
approved these changes
Nov 19, 2019
jmrossy
reviewed
Nov 19, 2019
| hideAlert={jest.fn()} | ||
| importContacts={jest.fn()} | ||
| loading={false} | ||
| appConnected={false} |
There was a problem hiding this comment.
I think this value gets overwritten by the value set in the provider store. I don't see the banner in the snapshot.
There was a problem hiding this comment.
Good catch. Updated to use createMockStoreAppDisconnected().
…o into annakaz/minor-bugs
annakaz
added
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tiny PR fixing the disconnected banner overlap in wallet home. This does not affect the UI when the banner is not shown
Tested
Added and ran jest tests
Related issues
Previously:
Now:
