Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] [Device Specific] User is unable to enter a decimal value in the “Amount” field on “Send or Request” screen while proceeding for “ Send or request “ payment. #1309

Closed
Lss-Ankit opened this issue Oct 11, 2019 · 6 comments · Fixed by #5701 or #5926
Closed

[Android] [Device Specific] User is unable to enter a decimal value in the “Amount” field on “Send or Request” screen while proceeding for “ Send or request “ payment. #1309

Lss-Ankit opened this issue Oct 11, 2019 · 6 comments · Fixed by #5701 or #5926
Assignees
@gnardini
Labels
bug Something isn't working Priority: P2 Major qa triaged label for issues that have been assigned a priority wallet

Comments

@Lss-Ankit
Copy link

App version: Play store build v1.5.0
Repro on: Samsung s4 mini (4.4.2), Samsung Galaxy Grand prime (5.1.1),
Does not repro on: Moto E (4.4.4), Samsung Galaxy S4 (5.0), Samsung Galaxy A5 (6.0.1), Samsung Galaxy A5 (7.0).
Priority: Medium
Testing Account: (315) 678-6563/Backup Kay

Repro Steps:

  1. Launch the app.
  2. Tap on + tab.
  3. Tap on Celo contact user.
  4. Enter an amount and tap on “.” (Dot) button on the keypad.
  5. Observe

Impact: User is blocked to send the dollar amount with cent while proceeding for payment.
Current Behavior: User is unable to enter a decimal value in the “Amount” field
Expected Behavior: User should be able to enter a decimal value in the “Amount” field
Attachment: Android_BlockedToSendDollarWithCent.mp4 (Bug observe at 14 sec)
@Lss-Ankit Lss-Ankit added bug Something isn't working qa wallet labels Oct 11, 2019
@nityas nityas added applications Priority: P2 Major triaged label for issues that have been assigned a priority labels Oct 14, 2019
@annakaz
Copy link
Contributor

annakaz commented Jul 22, 2020

Closing as this is no longer relevant following the redesign

@annakaz annakaz closed this as completed Jul 22, 2020
@Lss-Ankit
Copy link
Author

I have verified this issue on Valora build v1.0.0(10) and observed that user is not able to enter the decimal value in amount field
Verified on devices:

  1. Samsung galaxy S4(4.4.2)
  2. Samsung Galaxy Grand Prime(5.1.1)

Does not repro on: Samsung Galaxy A5(7.0)

Attachment: DecimalValue.MOV

@Lss-Ankit Lss-Ankit reopened this Aug 14, 2020
@Lss-Ankit
Copy link
Author

Hi @gnardini
I have verified this issue on Android internal build 1.2.0(1004294314) for Withdraw CELO page and Add Funds page also and observe that it is still reproduced.
Repro on devices: Samsung Galaxy A3(5.0.2) , Samsung galaxy S4(4.4.2)

@Lss-Ankit
Copy link
Author

Hi @gnardini
I have verified this issue on Android internal build 1.3.0(1004294316) for Withdraw CELO page and Add Funds page also and observe that it is still reproduced.
Repro on devices: Samsung Galaxy A3(5.0.2)

@gnardini gnardini mentioned this issue Nov 4, 2020
Merged
@mergify mergify bot closed this as completed in #5701 Nov 5, 2020
mergify bot pushed a commit that referenced this issue Nov 5, 2020
@gnardini
[Wallet] Add correct decimal separator on CELO Withdrawal (#5701)
4fdd7fe 
### Description

When withdrawing CELO using an OS that uses commas as decimal separators instead of dots (for example, Argentinian) the decimal portion was being cut off. It's not anymore with this PR.

### Tested

Manually

### Related issues

- Fixes #1309
@Lss-Ankit
Copy link
Author

Hi @gnardini Verified with task with using Android play store (internal build) v1.4.0 (1004294317) and found the following:

  • Dot or Comma is not shown when user is on CELO Buy/ Sell screen.
    Verified On device Samsung Galaxy A3(5.0.2)
    Hence reopening the ticket.

@Lss-Ankit Lss-Ankit reopened this Nov 10, 2020
@nityas nityas added tmp and removed tmp labels Nov 11, 2020
@gnardini gnardini mentioned this issue Nov 20, 2020
Merged
@mergify mergify bot closed this as completed in #5926 Nov 25, 2020
mergify bot pushed a commit that referenced this issue Nov 25, 2020
@gnardini
[Wallet] Fix decimals keyboard in some Samsung devices (#5926)
a2cf49d 
### Description

On some Samsung devices, the numpad when inputting decimal amounts was not showing the decimal separator (dot or comma).

This is because these Samsung devices apparently have the same value for the decimal pad constant than for the autocapitalize constant, which causes them to override each other (🤦 ).

### Tested

On a Samsung device:

Before:
![Screenshot_2020-11-20-13-31-32](https://user-images.githubusercontent.com/6062888/99824926-217c7e00-2b35-11eb-859c-79fefd2c9346.png)

After:
![Screenshot_2020-11-20-13-31-23](https://user-images.githubusercontent.com/6062888/99824924-204b5100-2b35-11eb-932c-9958f46d53f7.png)


### Related issues

- Fixes #1309

### Backwards compatibility

N/A
@ValoraQA
Copy link

Hi gnardini, I have verified this issue using Android internal build V1.15.1 & Test Flight build V1.15.1 & observed that issue is fixed now. User is able to enter decimal amount.
Verfied On Devices: Samsung Galaxy S4 (4.4.2), Samsung Galaxy S4 (5.0.1)

@leojoy95 leojoy95 mentioned this issue May 13, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 30, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 27, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 27, 2022
Open
@lili2311 lili2311 mentioned this issue May 17, 2023
Open
@lili2311 lili2311 mentioned this issue May 22, 2023
Open
@snyk-bot snyk-bot mentioned this issue Jun 10, 2023
Open
@lili2311 lili2311 mentioned this issue Jul 20, 2023
Open
This was referenced Nov 26, 2023
Open
Open
@lili2311 lili2311 mentioned this issue Dec 23, 2023
Open
@lili2311 lili2311 mentioned this issue Feb 3, 2024
Open
@lili2311 lili2311 mentioned this issue Mar 25, 2024
Open
@lili2311 lili2311 mentioned this issue Apr 15, 2024
Open
@lili2311 lili2311 mentioned this issue May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnardini gnardini

Labels
bug Something isn't working Priority: P2 Major qa triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
5 participants
@nityas @gnardini @annakaz @Lss-Ankit @ValoraQA