Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Users SBAT see updated gold exchange screen #1728

Closed
annakaz opened this issue Nov 14, 2019 · 1 comment · Fixed by #2167
Closed

[Wallet] Users SBAT see updated gold exchange screen #1728

annakaz opened this issue Nov 14, 2019 · 1 comment · Fixed by #2167
Assignees
@annakaz
Labels
feature Feature requests Priority: P2 Major triaged label for issues that have been assigned a priority wallet

Comments

@annakaz
Copy link
Contributor

annakaz commented Nov 14, 2019 •
edited
Loading

Expected Behavior

Users commit to direction(buy/sell gold) before entering the flow. UI matches mocks below

66881921-5e169700-ef7d-11e9-821c-b06cfcf37084

Figma

Current Behavior

Current exchange screen looks like this:
@annakaz annakaz added the wallet label Nov 14, 2019
@annakaz annakaz self-assigned this Nov 14, 2019
@annakaz annakaz mentioned this issue Nov 14, 2019
Closed
@annakaz annakaz changed the title [Wallet] Users SBAT new gold exchange screen [Wallet] Users SBAT see gold exchange screen with local currency and direction Nov 14, 2019
@annakaz annakaz changed the title [Wallet] Users SBAT see gold exchange screen with local currency and direction [Wallet] Users SBAT see updated gold exchange screen Nov 18, 2019
@annakaz
Copy link
Contributor Author

annakaz commented Nov 18, 2019

Separating local currency to another issue, as it will build on top of #1484

@annakaz annakaz mentioned this issue Nov 18, 2019
Closed
@annakaz annakaz added applications feature Feature requests Priority: P2 Major triaged label for issues that have been assigned a priority labels Nov 19, 2019
@annakaz annakaz mentioned this issue Dec 10, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 18, 2020
Open
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
@ashishb
Handle crash during rollback in CeloLatestSync mode (ethereum#111)
9ac5c99 
We don't have the full header chain in the CeloLatestSync mode,
therefore, a rollback beyond oldest fetched block will lead to a crash.
An example is described in celo-org/celo-monorepo#1728 (comment)

To prevent that, in CeloLatestSync mode, we do not roll back beyond the
oldest block. Note that since we fetch last 128 blocks, this will
interfere with a large scale re-org of the chain. In a PoA network, we
should not be expecting a re-org greater than 128 blocks anyways.
This was referenced Dec 15, 2023
Open
Open
@lili2311 lili2311 mentioned this issue Dec 20, 2023
Open
This was referenced Jan 1, 2024
Open
Open
@leojoy95 leojoy95 mentioned this issue Mar 16, 2024
Open
@leojoy95 leojoy95 mentioned this issue May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annakaz annakaz

Labels
feature Feature requests Priority: P2 Major triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] New exchange trade screen and fix ts build in celotool celo-org/celo-monorepo
1 participant
@annakaz