-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grouped Notifications should include outstanding payment requests #1744
Labels
enhancement
an improvement to an existing feature
Priority: P2
Major
triaged
label for issues that have been assigned a priority
wallet
Comments
nityas
added
wallet
applications
enhancement
an improvement to an existing feature
Priority: P2
Major
labels
Nov 15, 2019
7 tasks
@nityas I've notice that these two text have different prepositions in Figma file. Should not we use the same instead? Just curious :) |
The image on the left contains a summary of the information on the screen
to the right. If someone had 10 notifications, line items would not be
visible for all the requests, but it is still valuable information for a
user to know how many total requests they have hence the decision to put
the number before the label (the two titles are otherwise identical --
though I'd be very in favor of changing both to read 'for you'. @coreycelo
thoughts?)
…On Wed, Nov 27, 2019, 7:35 AM Ivan Sorokin ***@***.***> wrote:
@nityas <https://github.com/nityas> I've notice that these two text are
different in Figma file. Should not we use the same title instead?
[image: Screenshot 2019-11-27 at 16 33 20]
<https://user-images.githubusercontent.com/6160124/69736971-d2735700-1133-11ea-82d2-f012252b1db6.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1744?email_source=notifications&email_token=AAUP3EJWITDYAQVDYOWOQFTQV2HSJA5CNFSM4JN7TDAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJ4GOA#issuecomment-559137592>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUP3ELSJIPZ5H75GC2XMQLQV2HSJANCNFSM4JN7TDAA>
.
|
👍 for consistent language—"for you" is great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
an improvement to an existing feature
Priority: P2
Major
triaged
label for issues that have been assigned a priority
wallet
Expected Behavior
When a payment request is sent, a notification should be added to the notification center giving the user the option to either 'remind' or 'cancel' the payment request
figma link
Once the payment request is completed, this notification should be removed from the notification center.
Current Behavior
payment requests are not displayed.
The text was updated successfully, but these errors were encountered: