Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal should cover the whole screen on the Get Backup key screen #195

Closed
sallyjyl opened this issue Jul 25, 2019 · 1 comment
Closed

Modal should cover the whole screen on the Get Backup key screen #195

sallyjyl opened this issue Jul 25, 2019 · 1 comment
Labels
bug Something isn't working Priority: P3 Minor quick-fix Things that should be quick fixes- Good for first issues & ramping up triaged label for issues that have been assigned a priority wallet

Comments

@sallyjyl
Copy link
Contributor

Expected Behavior

Would expect the white spaces on the top/bottom to disappear.

Current Behavior

image
@sallyjyl sallyjyl changed the title Modal SBAT cover the whole screen on the Get Backup key screen Modal should cover the whole screen on the Get Backup key screen Jul 25, 2019
@jmrossy jmrossy added quick-fix Things that should be quick fixes- Good for first issues & ramping up bug Something isn't working labels Aug 21, 2019
@jmrossy jmrossy self-assigned this Oct 7, 2019
@nityas nityas added Priority: P3 Minor triaged label for issues that have been assigned a priority labels Oct 14, 2019
@jmrossy jmrossy mentioned this issue Oct 18, 2019
Closed
@jmrossy jmrossy removed their assignment Oct 18, 2019
aaronmgdr added a commit that referenced this issue Dec 10, 2019
@aaronmgdr
Fixes celo-org/celo-labs##195
ac80f17 
Replace footer on community page with our new footer
cmcewen pushed a commit that referenced this issue Dec 11, 2019
@aaronmgdr @cmcewen
Three little improvements to website (#2161)
eb5621f 
* Fix cropped icon on email form

* Better typing of screenSize HOC so that it doesn’t expect screen to be passed in when props are not explicitly set.

* Fixes celo-org/celo-labs##195

Replace footer on community page with our new footer

* Fix https://github.com/celo-org/celo-labs/issues/196

Add open graph preview image to build page

Add celo twitter handle to og

* Lint
@annakaz
Copy link
Contributor

annakaz commented May 27, 2020

Closing out outdated issues

@annakaz annakaz closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Priority: P3 Minor quick-fix Things that should be quick fixes- Good for first issues & ramping up triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmrossy @nityas @annakaz @sallyjyl