Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration support for feeless attestation #5426

Closed
jeanregisser opened this issue Oct 19, 2020 · 1 comment
Closed

Integration support for feeless attestation #5426

jeanregisser opened this issue Oct 19, 2020 · 1 comment
Assignees
Milestone

Comments

@jeanregisser
Copy link
Contributor

jeanregisser commented Oct 19, 2020

What's important about this?

Feeless attestation is a blocker for GA. We want to be sure the integration with the wallet is optimal.

Definition of "done"

Feeless attestation is integrated and fully functional.

What's involved in doing this work?

  • Help review PR related to feeless attestation
  • Give input when needed
  • Help write unit/e2e tests needed
  • Thorough test of each delivered PR related to feeless attestation

Open questions

  • ?
@jeanregisser jeanregisser added this to the Milestone 7 milestone Oct 19, 2020
mergify bot pushed a commit that referenced this issue Oct 31, 2020
### Description

Adds reCaptcha implementation behind a feature flag. If `KOMENCI` is `true`, after clicking on `Start` on the `VerificationEducationScreen` the user will be prompted with a reCaptcha challenge that they'll need to complete before being able to verify. It also adds [SafetyNet](https://developer.android.com/training/safetynet/attestation) which is a check for Android devices.

This is missing integration with KomenciKit

### Tested

By changing the value of the KOMENCI flag and seeing the captcha flow (captcha code is logged)

### Related issues

- Part of #5426
mergify bot pushed a commit that referenced this issue Nov 3, 2020
### Description

If someone uses a phone number from a sanctioned country, they get stuck with an error on the screen to input name & number and can't continue to use the app.

### Tested

On the simulator with phone numbers from each of the banned countries.

### Related issues

- Fixes #5661
- Part of #5426
mergify bot pushed a commit that referenced this issue Nov 6, 2020
### Description

- Adds a new item to the `NavigationDrawer` that opens a popup which allows a user to invite their friends.
- On the send flow, if the user is inviting someone, the 30 cent invite fee is no longer added and the transaction to send those 30 extra cents doesn't happen.

Those two things will only be enabled when the `KOMENCI` feature flag is turned on (it's off right now).

Note: Some of the texts are still under revision and might change.

### Other changes

Added a small change to the `VerificationEducationScreen` that was missing from a previous PR.
 
### Tested

Going through the Send flow inviting someone and seeing that no extra fee gets charged and nothing else unexpected happens. Also pressing on the Invite item on the drawer and trying to invite someone.

### Related issues

- Part of #5426
mergify bot pushed a commit that referenced this issue Nov 9, 2020
### Description

Removed the `name` from the invite link texts since it was using the user's names and it made no sense.

### Other changes

Fixed a typo `facil` -> `fácil`

### Tested

Manually

### Related issues

- Part of #5426

### Backwards compatibility

N/A
@nityas nityas added the feature Feature requests label Dec 1, 2020
@gnardini
Copy link
Contributor

gnardini commented Dec 3, 2020

The work on this is done for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants