Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Force Update" mechanism in Valora #5429

Closed
gnardini opened this issue Oct 19, 2020 · 0 comments · Fixed by #5430
Closed

Fix "Force Update" mechanism in Valora #5429

gnardini opened this issue Oct 19, 2020 · 0 comments · Fixed by #5430
Assignees
Labels

Comments

@gnardini
Copy link
Contributor

Expected Behavior

When the app version is lower than the minimum upload, a non-dismissable Update screen should appear.

Current Behavior

The update screen can be dismissed.

@gnardini gnardini self-assigned this Oct 19, 2020
@mergify mergify bot closed this as completed in #5430 Oct 21, 2020
mergify bot pushed a commit that referenced this issue Oct 21, 2020
### Description

The Update screen could be dismissed before this PR. It shouldn't be dismissable, the intention is to force the update.

I had to add the min required version in Redux to force the screen when backgrounding and reopening the app since if the app was reloaded the screen could still be skipped. This happened specially on Android.

### Tested

Locally changing the app version on both platforms.

### Related issues

- Fixes #5429
gnardini added a commit that referenced this issue Oct 21, 2020
### Description

The Update screen could be dismissed before this PR. It shouldn't be dismissable, the intention is to force the update.

I had to add the min required version in Redux to force the screen when backgrounding and reopening the app since if the app was reloaded the screen could still be skipped. This happened specially on Android.

### Tested

Locally changing the app version on both platforms.

### Related issues

- Fixes #5429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant