Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping verification if ODIS is down #5437

Closed
gnardini opened this issue Oct 19, 2020 · 0 comments · Fixed by #5438
Closed

Allow skipping verification if ODIS is down #5437

gnardini opened this issue Oct 19, 2020 · 0 comments · Fixed by #5438
Assignees
@gnardini
Labels
wallet

Comments

@gnardini
Copy link
Contributor

Expected Behavior

If ODIS happens to be down, the onboarding shouldn't get stuck in any screen.

Current Behavior

When going through the onboarding, the verification screen gets stuck because there is a permanent loading screen and the skip verification modal doesn't show up when you press on the header button.

Note: This is blocking the wallet e2e tests.
@gnardini gnardini self-assigned this Oct 19, 2020
@gnardini gnardini mentioned this issue Oct 19, 2020
Merged
@mergify mergify bot closed this as completed in #5438 Oct 20, 2020
mergify bot pushed a commit that referenced this issue Oct 20, 2020
@gnardini
[Wallet] Allow skipping verification if ODIS is down (#5438)
67b40d1 
### Description

ODIS is down in Alfajores right now and when doing the onboarding the app is stuck on the verification screen because there is a permanent loading screen and the skip verification modal doesn't show up. I copied the modal so that it's shown even if the screen is loading.

Note: This is blocking the wallet e2e tests.

### Tested

Manually and added a unit test.

### Related issues

- Fixes #5437
gnardini added a commit that referenced this issue Oct 21, 2020
@gnardini
[Wallet] Allow skipping verification if ODIS is down (#5438)
8b5ce89 
### Description

ODIS is down in Alfajores right now and when doing the onboarding the app is stuck on the verification screen because there is a permanent loading screen and the skip verification modal doesn't show up. I copied the modal so that it's shown even if the screen is loading.

Note: This is blocking the wallet e2e tests.

### Tested

Manually and added a unit test.

### Related issues

- Fixes #5437
This was referenced Jun 21, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 27, 2022
Open
@lili2311 lili2311 mentioned this issue Sep 25, 2023
Open
@leojoy95 leojoy95 mentioned this issue Dec 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnardini gnardini

Labels
wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] Allow skipping verification if ODIS is down celo-org/celo-monorepo
1 participant
@gnardini