Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce celocli size #5439

Closed
barbaraliau opened this issue Oct 19, 2020 · 9 comments
Closed

Reduce celocli size #5439

barbaraliau opened this issue Oct 19, 2020 · 9 comments
Assignees
Labels
Applications Applications circle tasks cli Priority: P2 Major stale

Comments

@barbaraliau
Copy link
Contributor

Expected Behavior

Should be able to install celocli on AWS t2.micro instance (free trial), or other similarly specced VMs

Current Behavior

VM crashes during celocli installation. RAM might be the issue.
yarn process halts and then the VM is unreachable by ssh until reboot

@barbaraliau
Copy link
Contributor Author

Proposed Solution

  • Determine minimum spec requirements goal for celocli
  • Reduce dependencies
  • Cut new release

Open Questions

  • What dependencies can be cut?
  • Does this depend on ContractKit modularization (I'm guessing yes)?
  • What is a reasonable spec requirement?
  • Should we include this in M7 CLI epic?

@medhakothari
Copy link
Contributor

Yah I think this should definitely be addressed for the cli, thanks for making the issue!

How much would the contractkit modularization solve this? From what I see on the modularization PR, seems like the cli would need access to most of the new proposed packages, such as extenders, communication, wallet libraries, etc, so not sure how much bundle size would be reduced from that front.
@gastonponti do you have more information here?

@gastonponti
Copy link
Contributor

@medhak1 you are right. It basically uses all the packages, so unless we decide to for example, remove the HSM wallet as a possibility, probably this PR won't impact on the cli size

@gastonponti
Copy link
Contributor

For example, if we could think more of the things required to be use in these kind of instances, and maybe make a light-cli, with just the basics, and supporting only one wallet.

@martinvol
Copy link
Contributor

I personally experienced this but it'd be great that someone else confirms it too.

@barbaraliau
Copy link
Contributor Author

barbaraliau commented Oct 27, 2020 via email

@aslawson
Copy link
Contributor

Closed related ticket: Improve celocli install time #579

@aslawson aslawson removed the epic label Jan 22, 2021
@aaronmgdr
Copy link
Member

#6193 should go a long way to fixing this as

@github-actions
Copy link
Contributor

This issue is stale and will be closed in 30 days without activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Applications circle tasks cli Priority: P2 Major stale
Projects
None yet
Development

No branches or pull requests

8 participants