Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validators and Groups SBAT see payments received #787

Closed
timmoreton opened this issue Aug 29, 2019 · 1 comment · Fixed by #2160
Closed

Validators and Groups SBAT see payments received #787

timmoreton opened this issue Aug 29, 2019 · 1 comment · Fixed by #2160
Assignees
@jfoutts-celo
Labels
audit cli protocol-tools

Comments

@timmoreton
Copy link
Contributor

timmoreton commented Aug 29, 2019 •
edited by asaj
Loading

Validators and groups currently have no way of viewing the payments they've received for validating, other than checking their balances before and after the last block of an epoch. This is an unreliable method, as they may have sent/received Celo Dollars during that block.

We should instead read this information from the block finalization receipts
@diminator
Copy link
Contributor

I can take this if there's a bit more explanation

@asaj asaj assigned jfoutts-celo and unassigned asaj Nov 26, 2019
@jfoutts-celo jfoutts-celo mentioned this issue Dec 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfoutts-celo jfoutts-celo

Labels
audit cli protocol-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli: Add rewards:show celo-org/celo-monorepo
4 participants
@timmoreton @asaj @diminator @jfoutts-celo