cli: Add rewards:show #2160
cli: Add rewards:show #2160
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2160 +/- ##
========================================
Coverage 74.66% 74.66%
========================================
Files 274 274
Lines 7732 7732
Branches 701 985 +284
========================================
Hits 5773 5773
Misses 1847 1847
Partials 112 112
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
General note before I did into this again. We really want to keep type safety, so any should be used sparingly. contractkit especially has gone to great lengths for type safety. A lot of the helper functions you introduce here break type safety by using any and you'll need to refactor it to to avoid that. Honestly I find too many helpers makes code hard to read, and I think many of these could be cut because they are only needed in one place anyway.
|
I'm going to be gone on vacation. I have no more concerns. Thanks for all the iterations on this! 👍 |
packages/contractkit/src/kit.ts
Outdated
| const validators = await this.contracts.getValidators() | ||
| const epochSize = await validators.getEpochSize() | ||
| const currentBlock = await this.web3.eth.getBlockNumber() | ||
| return Math.floor(currentBlock / epochSize) |
There was a problem hiding this comment.
is this correct? I recall the conversation where you stated that it should be:
epochNumber(blockNumber) => blockNumber / epochSize + (blockNumber % epochSize != 0)
There was a problem hiding this comment.
Updated to call smart contract getEpochNumber(). Note that definition ended up being off by one. I'm going off the definition in master UsingPrecompiles.
* master: (26 commits) Added new lint rule (#2349) [Slashing] Slash locked gold (#2317) [Slashing] Allow voting gold to be slashable (#2302) 1666 precompiles assembly rewrite (#2324) Small fixes to deploy web (#2343) Governance, downtime and double signing slasher contracts (#2267) Added daily limit for reserve spending (#2303) Fixing multisig tests (#2342) [Wallet] Implement new send & import flow (#2332) Limechain/16xx (#1982) Add infinite pagination to Leaderboard (#2339) cli: Add rewards:show (#2160) Correct broken link formatting Celotool command for deploying hotfixes (#2142) Governance ContractKit + CLI changes (#2139) Complete codependent slashing precompile PRs (#2333) Add new and modified precompiles to UsingPrecompiles.sol (#2318) Adding error messages to contracts (#1182) Upgrade i18next and react-i18next to latest across monorepo (#2311) [Wallet] Fix exchange input on iOS and feed item display (#2319) ... # Conflicts: # yarn.lock
* master: (35 commits) Remove rep sentence from brand kit page (#2350) Added new lint rule (#2349) [Slashing] Slash locked gold (#2317) [Slashing] Allow voting gold to be slashable (#2302) 1666 precompiles assembly rewrite (#2324) Small fixes to deploy web (#2343) Governance, downtime and double signing slasher contracts (#2267) Added daily limit for reserve spending (#2303) Fixing multisig tests (#2342) [Wallet] Implement new send & import flow (#2332) Limechain/16xx (#1982) Add infinite pagination to Leaderboard (#2339) cli: Add rewards:show (#2160) Correct broken link formatting Celotool command for deploying hotfixes (#2142) Governance ContractKit + CLI changes (#2139) Complete codependent slashing precompile PRs (#2333) Add new and modified precompiles to UsingPrecompiles.sol (#2318) Adding error messages to contracts (#1182) Upgrade i18next and react-i18next to latest across monorepo (#2311) ...
Description
Add rewards:show command that shows rewards for the last N epochs.
If --address is supplied: voter, validator, and validator group rewards applying to address are filtered.
Tested
Tested that rewards are correctly displayed by the CLI on my testnet.
Related issues