Add new and modified precompiles to UsingPrecompiles.sol #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
=======================================
Coverage 74.67% 74.67%
=======================================
Files 274 274
Lines 7731 7731
Branches 984 984
=======================================
Hits 5773 5773
Misses 1846 1846
Partials 112 112
Continue to review full report at Codecov.
|
mrsmkl
reviewed
Dec 20, 2019
| * @return address data | ||
| */ | ||
| function getAddressFromBytes(bytes memory bs, uint256 start) internal pure returns (address) { | ||
| require(bs.length >= start + 32, "slicing out of range"); |
There was a problem hiding this comment.
Should we reuse the code in these three functions?
There was a problem hiding this comment.
Updated to reuse. Now with only 2 usages of "assembly" left, this PR addresses #1666.
asaj
reviewed
Dec 20, 2019
| @@ -2,7 +2,16 @@ pragma solidity ^0.5.3; | |||
|
|
|||
| // TODO(asa): Limit assembly usage by using X.staticcall instead. | |||
| contract UsingPrecompiles { | |||
| address constant TRANSFER = address(0xff - 2); | |||
There was a problem hiding this comment.
Nice. Seems the mload from #2324 may be OK.
| require(bs.length >= start + 32, "slicing out of range"); | ||
| bytes32 x; | ||
| assembly { | ||
| x := mload(add(bs, add(0x20, start))) |
There was a problem hiding this comment.
Can you do add(bs, 32 + start)? IMO the decimal representation is more readable
| require(bs.length >= start + 32, "slicing out of range"); | ||
| bytes32 x; | ||
| assembly { | ||
| x := mload(add(bs, add(0x20, start))) |
There was a problem hiding this comment.
Why do we need to add 32 here?
There was a problem hiding this comment.
The first word of an array is the array size.
jfoutts-celo
approved these changes
Dec 20, 2019
| @@ -2,7 +2,16 @@ pragma solidity ^0.5.3; | |||
|
|
|||
| // TODO(asa): Limit assembly usage by using X.staticcall instead. | |||
| contract UsingPrecompiles { | |||
| address constant TRANSFER = address(0xff - 2); | |||
There was a problem hiding this comment.
Nice. Seems the mload from #2324 may be OK.
aaronmgdr
added a commit
that referenced
this pull request
Jan 2, 2020
* master: (26 commits) Added new lint rule (#2349) [Slashing] Slash locked gold (#2317) [Slashing] Allow voting gold to be slashable (#2302) 1666 precompiles assembly rewrite (#2324) Small fixes to deploy web (#2343) Governance, downtime and double signing slasher contracts (#2267) Added daily limit for reserve spending (#2303) Fixing multisig tests (#2342) [Wallet] Implement new send & import flow (#2332) Limechain/16xx (#1982) Add infinite pagination to Leaderboard (#2339) cli: Add rewards:show (#2160) Correct broken link formatting Celotool command for deploying hotfixes (#2142) Governance ContractKit + CLI changes (#2139) Complete codependent slashing precompile PRs (#2333) Add new and modified precompiles to UsingPrecompiles.sol (#2318) Adding error messages to contracts (#1182) Upgrade i18next and react-i18next to latest across monorepo (#2311) [Wallet] Fix exchange input on iOS and feed item display (#2319) ... # Conflicts: # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Jan 2, 2020
* master: (35 commits) Remove rep sentence from brand kit page (#2350) Added new lint rule (#2349) [Slashing] Slash locked gold (#2317) [Slashing] Allow voting gold to be slashable (#2302) 1666 precompiles assembly rewrite (#2324) Small fixes to deploy web (#2343) Governance, downtime and double signing slasher contracts (#2267) Added daily limit for reserve spending (#2303) Fixing multisig tests (#2342) [Wallet] Implement new send & import flow (#2332) Limechain/16xx (#1982) Add infinite pagination to Leaderboard (#2339) cli: Add rewards:show (#2160) Correct broken link formatting Celotool command for deploying hotfixes (#2142) Governance ContractKit + CLI changes (#2139) Complete codependent slashing precompile PRs (#2333) Add new and modified precompiles to UsingPrecompiles.sol (#2318) Adding error messages to contracts (#1182) Upgrade i18next and react-i18next to latest across monorepo (#2311) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add and modify functions in
UsingPrecompiles.solto account for new and modified precompiles in recentcelo-blockchainPRs (i.e. celo-org/celo-blockchain#772 and celo-org/celo-blockchain#767)Tested
numberValidatorsInCurrentSetandvalidatorSignerAddressFromCurrentSetare exercised in current end-to-end tests. Other changes are untested.Backwards compatibility
Fully backwards compatible