Governance ContractKit + CLI changes #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des/contract-upgrades
nambrot
requested review from
asaj,
cmcewen,
jmrossy,
m-chrzan and
mcortesi
as code owners
jmrossy
reviewed
Dec 10, 2019
…ot/contract-upgrades-cli
mcortesi
approved these changes
Dec 23, 2019
| const proposal = await buildProposalFromJsonFile(this.kit, res.flags.jsonTransactions) | ||
| const tx = governance.propose(proposal) | ||
| await displaySendTx('proposeTx', tx, { from: res.flags.from, value: res.flags.deposit }) | ||
| const proposalID = await tx.txo.call() |
There was a problem hiding this comment.
does this work?
you first "send the tx" and after that make the same call. But will it result on the same proposalID?
There was a problem hiding this comment.
definitely not
opened #2335
Codecov Report
@@ Coverage Diff @@
## master #2139 +/- ##
==========================================
- Coverage 74.67% 74.66% -0.01%
==========================================
Files 274 274
Lines 7731 7732 +1
Branches 700 701 +1
==========================================
Hits 5773 5773
- Misses 1846 1847 +1
Partials 112 112
Continue to review full report at Codecov.
|
…ot/contract-upgrades-cli
aaronmgdr
added a commit
that referenced
this pull request
Jan 2, 2020
* master: (26 commits) Added new lint rule (#2349) [Slashing] Slash locked gold (#2317) [Slashing] Allow voting gold to be slashable (#2302) 1666 precompiles assembly rewrite (#2324) Small fixes to deploy web (#2343) Governance, downtime and double signing slasher contracts (#2267) Added daily limit for reserve spending (#2303) Fixing multisig tests (#2342) [Wallet] Implement new send & import flow (#2332) Limechain/16xx (#1982) Add infinite pagination to Leaderboard (#2339) cli: Add rewards:show (#2160) Correct broken link formatting Celotool command for deploying hotfixes (#2142) Governance ContractKit + CLI changes (#2139) Complete codependent slashing precompile PRs (#2333) Add new and modified precompiles to UsingPrecompiles.sol (#2318) Adding error messages to contracts (#1182) Upgrade i18next and react-i18next to latest across monorepo (#2311) [Wallet] Fix exchange input on iOS and feed item display (#2319) ... # Conflicts: # yarn.lock
aaronmgdr
added a commit
that referenced
this pull request
Jan 2, 2020
* master: (35 commits) Remove rep sentence from brand kit page (#2350) Added new lint rule (#2349) [Slashing] Slash locked gold (#2317) [Slashing] Allow voting gold to be slashable (#2302) 1666 precompiles assembly rewrite (#2324) Small fixes to deploy web (#2343) Governance, downtime and double signing slasher contracts (#2267) Added daily limit for reserve spending (#2303) Fixing multisig tests (#2342) [Wallet] Implement new send & import flow (#2332) Limechain/16xx (#1982) Add infinite pagination to Leaderboard (#2339) cli: Add rewards:show (#2160) Correct broken link formatting Celotool command for deploying hotfixes (#2142) Governance ContractKit + CLI changes (#2139) Complete codependent slashing precompile PRs (#2333) Add new and modified precompiles to UsingPrecompiles.sol (#2318) Adding error messages to contracts (#1182) Upgrade i18next and react-i18next to latest across monorepo (#2311) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is all @yorhodes 's work to make governance proposals and hotfixes work in contractkit + CLI, just updated to master