Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency conversion in activity feed should use historical rate #834

Closed
jmrossy opened this issue Sep 4, 2019 · 0 comments · Fixed by #2446
Closed

Currency conversion in activity feed should use historical rate #834

jmrossy opened this issue Sep 4, 2019 · 0 comments · Fixed by #2446
Assignees
@jeanregisser
Labels
bug Something isn't working Priority: P1 Critical triaged label for issues that have been assigned a priority wallet

Comments

@jmrossy
Copy link
Contributor

jmrossy commented Sep 4, 2019

No description provided.

@nityas nityas added bug Something isn't working Priority: P1 Critical triaged label for issues that have been assigned a priority labels Oct 14, 2019
@annakaz annakaz mentioned this issue Oct 25, 2019
Closed
@annakaz annakaz removed their assignment Oct 30, 2019
This was referenced Nov 27, 2019
Merged
Merged
jeanregisser added a commit that referenced this issue Dec 5, 2019
@jeanregisser
Support fetched exchanged rate in string format
31c703a 
As part of the work on #834, I intend to switch the output format
for the exchange rate api to BigNumber serialized as string.
This makes the wallet be compatible with that new format too.
This way we can introduce the breaking change on the blockchain-api
without disrupting the upcoming release of the wallet.
@jeanregisser jeanregisser mentioned this issue Dec 5, 2019
Merged
jeanregisser added a commit that referenced this issue Dec 5, 2019
@jeanregisser
[Wallet] Compatibility with exchange rate in string format (#2060)
fe32d2f 
As part of the work on #834, I intend to switch the output format for the exchange rate api to BigNumber serialized as string.
This makes the wallet compatible with that new format too.
This way we can introduce the breaking change on the blockchain-api when it's ready without disrupting the upcoming release of the wallet (which will be incompatible with the upcoming alfajores network upgrade).
@jeanregisser jeanregisser mentioned this issue Dec 9, 2019
Merged
@jeanregisser jeanregisser mentioned this issue Jan 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanregisser jeanregisser

Labels
bug Something isn't working Priority: P1 Critical triaged label for issues that have been assigned a priority wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Wallet] Historical currency conversions in the transaction feed celo-org/celo-monorepo
4 participants
@jeanregisser @jmrossy @nityas @annakaz