Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LockedGold.slash() should only payout to reporters who are registered on Accounts #8828

Closed
yorhodes opened this issue Oct 20, 2021 · 0 comments · Fixed by #8854
Closed

LockedGold.slash() should only payout to reporters who are registered on Accounts #8828

yorhodes opened this issue Oct 20, 2021 · 0 comments · Fixed by #8854
Assignees
@m-chrzan
Labels
CAP Component: Contracts

Comments

@yorhodes
Copy link
Contributor

Expected Behavior

Revert on non accounts in LockedGold.slash()

Current Behavior

ie signer accounts can receive lockedgold which will never be retrievable (signers cannot create accounts)
@yorhodes yorhodes changed the title LockedGold.slash() should only payout to reporters who are registered on Accounts LockedGold.slash() should only payout to reporters who are registered on Accounts Oct 20, 2021
This was referenced Oct 23, 2021
Open
Open
Open
Open
Open
@m-chrzan m-chrzan mentioned this issue Oct 26, 2021
Merged
This was referenced Oct 27, 2021
Open
Open
Open
Open
Open
This was referenced Nov 3, 2021
Open
Open
Open
Open
Open
@mergify mergify bot closed this as completed in #8854 Nov 8, 2021
mergify bot pushed a commit that referenced this issue Nov 8, 2021
@m-chrzan
Require that slashing reporters are accounts (#8854)
de0a002 
### Description

Slashing is incentivized with a reward of locked CELO going from the slashee to the reporter. Locked CELO is tied to accounts from the Accounts core contract, so we require that reporters have created an account.

### Other changes

Reworded a description string for an unrelated test.

### Tested

Unit tests.

### Related issues

- Fixes #8828

### Backwards compatibility

This change doesn't change storage layouts or function signatures.
This was referenced Nov 8, 2021
Open
Open
Open
Open
This was referenced Nov 16, 2021
Open
Open
Open
Open
This was referenced Apr 21, 2022
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue May 1, 2022
Open
This was referenced May 26, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Jun 5, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 26, 2022
Open
@leojoy95 leojoy95 mentioned this issue Jun 27, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 27, 2022
Open
This was referenced Aug 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 8, 2022
Open
This was referenced Oct 6, 2022
Open
Open
This was referenced Apr 24, 2023
Open
Open
Open
This was referenced Jun 23, 2023
Open
Open
Open
Open
@lili2311 lili2311 mentioned this issue Jun 24, 2023
Open
@lili2311 lili2311 mentioned this issue Dec 10, 2023
Open
This was referenced May 22, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-chrzan m-chrzan

Labels
CAP Component: Contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Require that slashing reporters are accounts celo-org/celo-monorepo
2 participants
@yorhodes @m-chrzan