Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M01] Contract registry has no entry for BRL #8998

Closed
cylon56 opened this issue Nov 20, 2021 · 1 comment
Closed

[M01] Contract registry has no entry for BRL #8998

cylon56 opened this issue Nov 20, 2021 · 1 comment
Labels

Comments

@cylon56
Copy link

cylon56 commented Nov 20, 2021

Contract registry has no entry for BRL

In PR #8831, the UsingRegistryV2 contract provides various getters returning addresses for contracts comprising the Celo protocol. For each featured protocol contract, a constant pointer is defined and used to inform the corresponding getter. While this mechanism isn't too complex, duplicating this process in code for a particular contract can lead to errors.

The problem is that the EUR token has corresponding getters for its registry and exchange, while the BRL token does not. So retrieval of corresponding BRL contract address would require code that may be error prone and not follow the standard defined by the UsingRegistryV2 contract.

Consider defining within the UsingRegistryV2 contract getters corresponding to the BRL token.

Part of the OpenZeppelin Release 6 Audit: @georgercarder @clarkhenry

martinvol added a commit to luisgj/celo-monorepo that referenced this issue Nov 22, 2021
martinvol added a commit to luisgj/celo-monorepo that referenced this issue Nov 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

This issue is stale and will be closed in 30 days without activity

@github-actions github-actions bot added the stale label Feb 5, 2023
@github-actions github-actions bot closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant