Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M02] Incorrect token initialization data #8999

Closed
cylon56 opened this issue Nov 20, 2021 · 1 comment
Closed

[M02] Incorrect token initialization data #8999

cylon56 opened this issue Nov 20, 2021 · 1 comment

Comments

@cylon56
Copy link

cylon56 commented Nov 20, 2021

Incorrect token initialization data

In PR #8831, the migrationsConfig.js file is updated to include initialization data for the deployment of the StableTokenBRL.

This initialization data is incorrectly set to be a copy of the StableTokenEUR initialization data. Specifically the tokenName and tokenSymbol are set incorrectly to Celo Euro and cEUR.

This incorrect token initialization will not affect the inner logic and accounting of the token itself. However, this mislabelling can cause errors in indexing this token in exchanges, and will likely confuse users which can greatly affect its utility and adoption.

Consider updating the migrationsConfig.js to have appropriate tokenName and tokenSymbol set specific to the StableTokenBRL.

Part of the OpenZeppelin Release 6 Audit: @georgercarder @clarkhenry

martinvol added a commit to luisgj/celo-monorepo that referenced this issue Nov 22, 2021
@martinvol
Copy link
Contributor

As a clarification, wanted to point out that file is only used for testing proposals and not for mainnet (not even testnets).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants