Use blockchain master for e2e tests #10402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palango
force-pushed
the
palango/blockchain-master
branch
from
05d60bd
to
3df2842
Compare
palango
force-pushed
the
palango/blockchain-master
branch
from
3df2842
to
3d97ffc
Compare
|
Depending directly on master will cause problems with reproducibility. Alternatively, we could regularly update to the latest commit hash from celo-blockchain master. That would also allow us to include necessary fixes in the same PR as the commit hash update. On the other hand, do we have the necessary discipline/process to frequently update the commit hash and check the results? In any case, I am strongly in favour of having a more recent celo-blockchain dependency than the latest stable release! |
|
I didn't find an explanation, yet. The test also succeeds locally and uses celo-blockchain's current master (e10394dfcaef2825ca799c97ddea3d3e78593724). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return to running the e2e tests against blockchain master.