Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODIS 3.0.0 Release Branch #10462

Merged
merged 72 commits into from
Aug 30, 2023
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
2cbc3af
sdks 4.1.1-beta.1, pnpcommon 3.0.0-beta.1
alecps Aug 2, 2023
79b1c02
fix sdk release script and formatting
alecps Aug 2, 2023
4126699
remove unneccessary combiner dependency
alecps Aug 2, 2023
bf8e8cd
Merge branch 'master' into alecps/odisRelease3.0.0
alecps Aug 3, 2023
13fba4d
get rid of trx
alecps Aug 3, 2023
ba225a7
update signer version used in combiner integration tests
alecps Aug 3, 2023
b9d8bd8
add metering
alecps Aug 3, 2023
da4333d
get rid of trx
alecps Aug 3, 2023
8e50c01
highlighting other relevant code for reviewers
alecps Aug 3, 2023
a4665e9
highlighting other relevant code for reviewers again
alecps Aug 3, 2023
f44e7b3
Soloseng/fix-release (#10466)
soloseng Aug 3, 2023
e13e889
add back trx
alecps Aug 7, 2023
74d576a
rename tableWithLockForTrx to queryWithOptionalTrx
alecps Aug 9, 2023
b49315d
drive-by remove attestations from config
alecps Aug 9, 2023
081af8a
remove comment
alecps Aug 9, 2023
27c099f
Merge branch 'alecps/odisRemoveDbLock' of github.com:celo-org/celo-mo…
alecps Aug 9, 2023
75caabe
add back trx
alecps Aug 9, 2023
eb08a77
add back trx comment
alecps Aug 9, 2023
a8d3d1e
add back rollack
alecps Aug 9, 2023
c83bac1
bump version numbers to beta.3
alecps Aug 9, 2023
4b5fcb6
mock combiner authentication
alecps Aug 21, 2023
5a9b4f9
Odis signer refactor (#10464)
alecps Aug 21, 2023
785dd11
Merge remote-tracking branch 'origin/master' into alecps/odisRelease3…
mcortesi Aug 21, 2023
c26a90b
Combiner tracing - staging (#10496)
alvarof2 Aug 21, 2023
5f61a5b
removed blocknumber (#10507)
soloseng Aug 22, 2023
3abfd6b
Signer mock interfaces (#10510)
alecps Aug 22, 2023
dbe554d
add moving avg to load test (#10509)
alecps Aug 23, 2023
3b5f635
Big Refactor of the combiner (#10513)
mcortesi Aug 23, 2023
577bee2
fix lint errors
alecps Aug 23, 2023
9b80d41
fix unit tests
alecps Aug 23, 2023
80efb75
fix issue on domainQuota signer endpoint
mcortesi Aug 23, 2023
cdf98b5
publish common package for combiner deploy
alecps Aug 23, 2023
c9c34e9
Merge branch 'alecps/odisRelease3.0.0' of github.com:celo-org/celo-mo…
alecps Aug 23, 2023
bfbf63c
implement AbortSignal any
alecps Aug 24, 2023
1c01f35
add back log based metrics
alecps Aug 24, 2023
56727bf
add back trx, fix signer tests
alecps Aug 24, 2023
f6141ac
prevent loadtest from crashing on error response (#10517)
soloseng Aug 25, 2023
536232e
Set user agent to the kit (#10518)
gastonponti Aug 25, 2023
0795d07
Add Remove database error (#10519)
gastonponti Aug 25, 2023
0837937
fix log based metric
alecps Aug 25, 2023
877bc13
store signature in requests table (#10520)
alecps Aug 25, 2023
fcfaf14
fix keyVersion parsing
alecps Aug 25, 2023
7b21419
fix fallback url bug
alecps Aug 25, 2023
c9fd92f
lint fix + bump combiner version
alecps Aug 25, 2023
40a72ea
make signature optional
alecps Aug 25, 2023
6911a6b
Signer Database requests prunning (#10521)
gastonponti Aug 26, 2023
0c03ba3
Fixed linter
soloseng Aug 28, 2023
bd6dd5f
decrease coverage threshold 76% -> 68%
soloseng Aug 28, 2023
3bbbd0a
Add index in timestamp (#10525)
gastonponti Aug 28, 2023
ec9fa41
Merge branch 'master' of github.com:celo-org/celo-monorepo into alecp…
alecps Aug 28, 2023
0eddb91
Update packages/phone-number-privacy/signer/src/pnp/services/request-…
gastonponti Aug 28, 2023
82c5c84
fix signer e2e tests
alecps Aug 28, 2023
d72f96e
Merge branch 'alecps/odisRelease3.0.0' of github.com:celo-org/celo-mo…
alecps Aug 28, 2023
5c825f6
add TODO
alecps Aug 28, 2023
3597a8a
fix response metrics
alecps Aug 28, 2023
39369e2
misc cosmetic changes from review
alecps Aug 29, 2023
7ce3511
remove unused code from common pkg
alecps Aug 29, 2023
188770a
misc edits, remove unused test
alecps Aug 29, 2023
8c950b4
remove blockNumber from response type schemas
alecps Aug 29, 2023
0c91381
publish common package and bump odis versions
alecps Aug 29, 2023
cbda21b
use 4.1.1-dev everywhere except for ODIS packages
alecps Aug 29, 2023
da7d21b
revert change to identity sdk
alecps Aug 29, 2023
6f6a8ea
add back change to identity sdk
alecps Aug 29, 2023
4a9f50f
remove duplicate countAndThrowDBError in domains request table wrapper
alecps Aug 29, 2023
3a53e17
misc fixes from reviewing metrics
alecps Aug 30, 2023
18e9024
add TODO statements and remove unused QService
alecps Aug 30, 2023
e0bd90c
misc cleanup
alecps Aug 30, 2023
a1eddbe
cleanup combiner comments
alecps Aug 30, 2023
31ec781
remove combiner comment
alecps Aug 30, 2023
e28be05
remove old combiner e2e test
alecps Aug 30, 2023
63eaae5
fix signer e2e test
alecps Aug 30, 2023
7f9fbb1
remove blockNumber from combiner e2e tests and add TODO to fix remain…
alecps Aug 30, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"[typescript]": {
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": true
"source.organizeImports": false
}
},
"[typescriptreact]": {
Expand All @@ -43,5 +43,6 @@
"javascript.format.enable": false,
"editor.tabSize": 2,
"editor.detectIndentation": false,
"tslint.jsEnable": true
"tslint.jsEnable": true,
"typescript.tsdk": "node_modules/typescript/lib"
}
1 change: 0 additions & 1 deletion dependency-graph.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
"@celo/encrypted-backup",
"@celo/identity",
"@celo/phone-number-privacy-common",
"@celo/phone-number-privacy-signer",
"@celo/phone-utils",
"@celo/utils"
]
Expand Down
22 changes: 11 additions & 11 deletions packages/celotool/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,18 @@
"author": "Celo",
"license": "Apache-2.0",
"dependencies": {
"@celo/base": "4.1.1-dev",
"@celo/connect": "4.1.1-dev",
"@celo/cryptographic-utils": "4.1.1-dev",
"@celo/contractkit": "4.1.1-dev",
"@celo/base": "4.1.1-beta.1",
"@celo/connect": "4.1.1-beta.1",
"@celo/cryptographic-utils": "4.1.1-beta.1",
"@celo/contractkit": "4.1.1-beta.1",
"@celo/env-tests": "1.0.0",
"@celo/explorer": "4.1.1-dev",
"@celo/governance": "4.1.1-dev",
"@celo/identity": "4.1.1-dev",
"@celo/network-utils": "4.1.1-dev",
"@celo/utils": "4.1.1-dev",
"@celo/explorer": "4.1.1-beta.1",
"@celo/governance": "4.1.1-beta.1",
"@celo/identity": "4.1.1-beta.1",
"@celo/network-utils": "4.1.1-beta.1",
"@celo/utils": "4.1.1-beta.1",
"@ethereumjs/util": "8.0.5",
"@ethereumjs/rlp":"4.0.1",
"@ethereumjs/rlp": "4.0.1",
"@google-cloud/monitoring": "0.7.1",
"@google-cloud/pubsub": "^0.28.1",
"@google-cloud/secret-manager": "3.0.0",
Expand Down Expand Up @@ -66,4 +66,4 @@
"build": "tsc -b ."
},
"private": true
}
}
20 changes: 10 additions & 10 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,16 @@
},
"dependencies": {
"@celo/bls12377js": "0.1.1",
"@celo/contractkit": "^4.1.1-dev",
"@celo/explorer": "^4.1.1-dev",
"@celo/governance": "^4.1.1-dev",
"@celo/identity": "^4.1.1-dev",
"@celo/phone-utils": "^4.1.1-dev",
"@celo/utils": "^4.1.1-dev",
"@celo/cryptographic-utils": "^4.1.1-dev",
"@celo/wallet-hsm-azure": "^4.1.1-dev",
"@celo/wallet-ledger": "^4.1.1-dev",
"@celo/wallet-local": "^4.1.1-dev",
"@celo/contractkit": "^4.1.1-beta.1",
"@celo/explorer": "^4.1.1-beta.1",
"@celo/governance": "^4.1.1-beta.1",
"@celo/identity": "^4.1.1-beta.1",
"@celo/phone-utils": "^4.1.1-beta.1",
"@celo/utils": "^4.1.1-beta.1",
"@celo/cryptographic-utils": "^4.1.1-beta.1",
"@celo/wallet-hsm-azure": "^4.1.1-beta.1",
"@celo/wallet-ledger": "^4.1.1-beta.1",
"@celo/wallet-local": "^4.1.1-beta.1",
"@ledgerhq/hw-transport-node-hid": "^6.27.4",
"@oclif/command": "^1.6.0",
"@oclif/config": "^1.6.0",
Expand Down
14 changes: 7 additions & 7 deletions packages/env-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
"main": "index.js",
"license": "MIT",
"dependencies": {
"@celo/contractkit": "4.1.1-dev",
"@celo/utils": "4.1.1-dev",
"@celo/base": "4.1.1-dev",
"@celo/connect": "4.1.1-dev",
"@celo/identity": "4.1.1-dev",
"@celo/phone-utils": "4.1.1-dev",
"@celo/cryptographic-utils": "4.1.1-dev",
"@celo/contractkit": "4.1.1-beta.1",
"@celo/utils": "4.1.1-beta.1",
"@celo/base": "4.1.1-beta.1",
"@celo/connect": "4.1.1-beta.1",
"@celo/identity": "4.1.1-beta.1",
"@celo/phone-utils": "4.1.1-beta.1",
"@celo/cryptographic-utils": "4.1.1-beta.1",
"bunyan": "1.8.12",
"bunyan-gke-stackdriver": "0.1.2",
"bunyan-debug-stream": "2.0.0",
Expand Down
8 changes: 4 additions & 4 deletions packages/metadata-crawler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
"homepage": "https://github.com/celo-org/celo-monorepo/tree/master/packages/metadata-crawler",
"repository": "https://github.com/celo-org/celo-monorepo/tree/master/packages/metadata-crawler",
"dependencies": {
"@celo/connect": "4.1.1-dev",
"@celo/contractkit": "4.1.1-dev",
"@celo/utils": "4.1.1-dev",
"@celo/connect": "4.1.1-beta.1",
"@celo/contractkit": "4.1.1-beta.1",
"@celo/utils": "4.1.1-beta.1",
"@types/pg": "^7.14.3",
"bunyan": "1.8.12",
"bunyan-gke-stackdriver": "0.1.2",
Expand All @@ -34,4 +34,4 @@
"clean:all": "yarn clean && rm -rf lib"
},
"private": true
}
}
25 changes: 25 additions & 0 deletions packages/phone-number-privacy/TODO.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# TODO

- (alec) fix domains tests
- (Alec) check prometheus Counter
- Fix types in errorResult and sendFailure so we don't have to use ANY
- Refactor domain sign handler to use db transactions properly
- refactor authorization function with the new account model
- resolve FAKE_URL for request url
- Search for TODO comments for things to fix after load test
- (nice to have) Refactor Combiner to be similar than signer (kill IO, Controller, Action)
alecps marked this conversation as resolved.
Show resolved Hide resolved
- Make caching config parameters configurable by environment
- TODO comments

## Done

✔️ extract resultHandler() out of each handler, into the createHandler on server.ts
✔️ correct Locals Type (logger should not be an ANY)
✔️ (mariano) Implement chaching Account Service
✔️ (mariano) Check Tracing Calls
✔️ trace signature timeg
✔️ (Mariano) remove catchErrorHandler2 (move it catchErrorHandler)
✔️ Type Handler so Response has the correct Response Type
✔️ Type Handlers so that Request is the proper type, or better use the "isValid Request" function
✔️ fix primary key in requests table
✔️ drop legacy tables
3 changes: 3 additions & 0 deletions packages/phone-number-privacy/combiner/.env
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ SERVICE_NAME='odis-combiner'
# For e2e Tests
ODIS_BLOCKCHAIN_PROVIDER=https://alfajores-forno.celo-testnet.org
CONTEXT_NAME='alfajores'
NODE_OPTIONS='--require ./dist/tracing.js'
TRACER_ENDPOINT='https://grafana-agent.staging-odis2-centralus.celo-networks-dev.org/api/traces'
TRACING_SERVICE_NAME='odis-combiner-staging'
29 changes: 17 additions & 12 deletions packages/phone-number-privacy/combiner/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@celo/phone-number-privacy-combiner",
"version": "3.0.0-dev",
"version": "3.0.0-beta.5",
"description": "Orchestrates and combines threshold signatures for use in ODIS",
"author": "Celo",
"license": "Apache-2.0",
Expand Down Expand Up @@ -28,12 +28,20 @@
"test:e2e:alfajores": "CONTEXT_NAME=alfajores yarn test:e2e"
},
"dependencies": {
"@celo/contractkit": "^4.1.1-dev",
"@celo/phone-number-privacy-common": "^3.0.0-dev",
"@celo/identity": "^4.1.1-dev",
"@celo/encrypted-backup": "^4.1.1-dev",
"@celo/contractkit": "^4.1.1-beta.1",
"@celo/phone-number-privacy-common": "^3.0.0-beta.2",
"@celo/identity": "^4.1.1-beta.1",
"@celo/encrypted-backup": "^4.1.1-beta.1",
"@celo/poprf": "^0.1.9",
"@types/bunyan": "^1.8.8",
"@opentelemetry/api": "^1.4.1",
"@opentelemetry/auto-instrumentations-node": "^0.38.0",
"@opentelemetry/exporter-jaeger": "^1.15.2",
"@opentelemetry/propagator-ot-trace": "^0.27.0",
"@opentelemetry/sdk-metrics": "^1.15.2",
"@opentelemetry/sdk-node": "^0.41.2",
"@opentelemetry/sdk-trace-web": "^1.15.2",
"@opentelemetry/semantic-conventions": "^1.15.2",
"blind-threshold-bls": "https://github.com/celo-org/blind-threshold-bls-wasm#e1e2f8a",
"dotenv": "^8.2.0",
"express": "^4.17.1",
Expand All @@ -45,18 +53,15 @@
"uuid": "^7.0.3"
},
"devDependencies": {
"@celo/utils": "^4.1.1-dev",
"@celo/phone-utils": "^4.1.1-dev",
"@celo/utils": "^4.1.1-beta.1",
"@celo/phone-utils": "^4.1.1-beta.1",
"@types/express": "^4.17.6",
"@types/supertest": "^2.0.12",
"@types/uuid": "^7.0.3",
"firebase-functions-test": "^3.1.0",
"firebase-tools": "12.4.7"
},
"peerDependencies": {
"@celo/phone-number-privacy-signer": "^3.0.0-dev"
},
"engines": {
"node": ">=18"
"node": "18"
}
}
}
8 changes: 0 additions & 8 deletions packages/phone-number-privacy/combiner/src/common/action.ts

This file was deleted.

Loading
Loading