Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EUROCEUR.yaml #10568

Closed
wants to merge 2 commits into from
Closed

Conversation

philbow61
Copy link
Collaborator

Description

  • with 3 price sources 3/3 is a bit too tight
  • changing it to 2/3

Other changes

  • n/a

Tested

  • n/a

Related issues

  • n/a

Backwards compatibility

  • n/a

Documentation

  • n/a

@philbow61 philbow61 requested a review from a team September 15, 2023 12:37
@philbow61 philbow61 requested a review from a team as a code owner September 15, 2023 12:37
@gitguardian
Copy link

gitguardian bot commented Sep 26, 2023

⚠️ GitGuardian has uncovered 16 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
4218548 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218548 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218548 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218548 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218549 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218549 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218549 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218549 PostgreSQL Credentials 6ffd48a .env.rc1 View secret
4218555 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
4218555 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
4218556 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
4218556 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
4218556 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
4218556 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
4218556 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
4218556 PostgreSQL Credentials 6ffd48a .env.alfajores View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@nvtaveras nvtaveras enabled auto-merge (squash) September 26, 2023 19:49
@nvtaveras
Copy link
Collaborator

Closing, will be included as part of #10626

@nvtaveras nvtaveras closed this Sep 26, 2023
auto-merge was automatically disabled September 26, 2023 21:01

Pull request was closed

@philbow61 philbow61 deleted the philbow61/EUROCEUR-helm-chart-update branch November 28, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants