Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: Removing Odis Identifiers and Hashing Functions #10708

Merged
merged 40 commits into from
Nov 13, 2023

Conversation

aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Nov 7, 2023

This will be replacement for #10664

It removes

  • identifiers from celo/base
  • getPhoneHash from celo/phone-utils

as a result these packages will both receive major bumps next release

fixes #10691

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: c74feae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@celo/phone-utils Major
@celo/base Major
@celo/celotool Major
@celo/celocli Patch
@celo/env-tests Patch
@celo/protocol Patch
@celo/connect Patch
@celo/contractkit Patch
@celo/cryptographic-utils Patch
@celo/explorer Patch
@celo/governance Patch
@celo/transactions-uri Patch
@celo/utils Patch
@celo/wallet-base Patch
@celo/wallet-hsm-azure Patch
@celo/wallet-hsm Patch
@celo/wallet-ledger Patch
@celo/wallet-rpc Patch
@celo/wallet-hsm-aws Patch
@celo/wallet-hsm-gcp Patch
@celo/wallet-local Patch
@celo/wallet-remote Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Nov 7, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@aaronmgdr aaronmgdr changed the title WIP Aaronmgdr/odis expel 2 Re: Removing Odis Identifiers and Hashing Functions Nov 9, 2023
@aaronmgdr aaronmgdr marked this pull request as ready for review November 9, 2023 13:25
@aaronmgdr aaronmgdr requested review from a team as code owners November 9, 2023 13:25
@aaronmgdr aaronmgdr requested review from a team and lvpeschke November 9, 2023 13:25
# Conflicts:
#	.github/workflows/celo-monorepo.yml
# Conflicts:
#	.github/workflows/celo-monorepo.yml
#	packages/cli/src/commands/account/offchain-read.ts
#	packages/cli/src/utils/off-chain-data.ts
#	yarn.lock
# Conflicts:
#	packages/protocol/package.json
@aaronmgdr aaronmgdr enabled auto-merge (squash) November 13, 2023 13:03
@aaronmgdr aaronmgdr merged commit 97d5ccf into master Nov 13, 2023
35 checks passed
@aaronmgdr aaronmgdr deleted the aaronmgdr/odis-expel-2 branch November 13, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove odis identifier hashing
2 participants