Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize Migrated Contracts #10817

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Conversation

soloseng
Copy link
Contributor

@soloseng soloseng commented Dec 8, 2023

Description

Organized the migrated contracts to keep the same structure as the contracts folder.

Other changes

  • Removed unused imports

  • Added parent contract name to test contracts. (this is usefull when running test with match-contract flag

Tested

unit tested

@soloseng soloseng requested a review from a team as a code owner December 8, 2023 17:22
Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: 82ee2e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@soloseng soloseng self-assigned this Dec 8, 2023
@soloseng soloseng enabled auto-merge (squash) December 8, 2023 17:22
@martinvol
Copy link
Contributor

Taking advantage of this refactor I went ahead and added aliases (remappings) of the contracts to make it consistent and more clear.

@soloseng soloseng merged commit b4aa051 into master Dec 11, 2023
35 checks passed
@soloseng soloseng deleted the soloseng/organize-migrated-contracts branch December 11, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants