replace tslint with eslint for typescript #10900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i thought it was ready because the linting passed but now the build fails. down the hole i've gone |
* remove many unneeded awaits and asyncs * change console logs to console info * ignore some more offensive files * fix some interprolated values which could have been [object object] * add missing dependencies * try to have minimal changes
Fix env tests use of typescript 4.0 for protocol package cannot extend because of bug in ts-node so instead just copy the config. remove tslint.json files
try es6 target (why not?) add package validation
aaronmgdr
force-pushed
the
aaronmgdr/eslint
branch
from
767eeb1 to
c29af98
Compare
… had been for tslint most of use dont need to decrypt to dont try automatically
…y this otherwise revert
… well as number keys) but NOT as arrays.
Closed
…ng all the bugs jut keep as is and sourcemaps are not needed for this package
lvpeschke
pushed a commit
that referenced
this pull request
Feb 26, 2024
* replace tslint with eslint for typescript * remove many unneeded awaits and asyncs * change console logs to console info * ignore some more offensive files * fix some interprolated values which could have been [object object] * add missing dependencies * try to have minimal changes * use tsconfig/recommended instead of our tsconfig library as base. Fix env tests use of typescript 4.0 for protocol package cannot extend because of bug in ts-node so instead just copy the config. remove tslint.json files * fix lint again * dont add strict mode, its too brutal, * add package validation * help out future devs with instructions on how to fix error * it works on my machine ok * trust but verify. but dont actually trust * use latest ts-node AND always run yarn ts-node to ensure the project one is used. * removing patch-package since the only remaining place it was used was had been for tslint * most of us dont need to decrypt to dont try automatically * i think running in yarn added extra output that broke gh action so try this otherwise revert * structs fro sol contracts are returned as objects with named keys (as well as number keys) but NOT as arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
goal here is just the switch over with minimal changes. therefore some rules are off and some script files are ignored as it does not seem that necessary to fix 100 lint errors in a script that is known to work and which i may actually introduce bugs in.
also
bump to typescript 5
Tested
linted till green
Related issues
Backwards compatibility
yes
Documentation
n/a