-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soloseng/celo-minting-schedule #10995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
This should be fine since it's only being used by MintGoldSchedule
Soloseng/celo-minting-schedule
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
pahor167
reviewed
Jun 4, 2024
pahor167
reviewed
Jun 4, 2024
pahor167
reviewed
Jun 4, 2024
pahor167
reviewed
Jun 4, 2024
pahor167
reviewed
Jun 4, 2024
pahor167
reviewed
Jun 4, 2024
pahor167
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a contract
MintGoldSchedule.sol
that calculates the amount of CELO to mint and distribute to the community fund and carbon offsetting fund address. This contract can be deployed on L1, but will only be activated on L2 by callingMintGoldSchedule.setDependencies()
.This schedule is based on the existing schedule previously defined by
EpochRewards
contract. In this new schedule, only the percentage of CELO allocated to community rewards and carbon offsetting fund is minted.As with the L1 minting schedule, the L2 minting schedule in only defined for the first 15 years after L1 genesis block. Future modification to the
MintGoldSchedule
contract will be required to define a schedule beyond the first 15 years. Additionally, setting the distribution fraction for any fund is prohibited once the first 15 years have elapsed.GoldToken.sol
was updated to only allow minting by the owner or theMintGoldSchedule
contract.Other changes
IGoldToken.sol
interface was added to allowMintGoldSchedule
to callGoldToken.mint()
.MockGovernance
contract, using pragma 0.8, was added to allow testing of theMintGoldSchedule
. UsingdeployCodeTo("Governance.sol", abi.encode(false), governanceAddress);
does not work, as the Governance contract bytecode has a placeholder for the libraries that it is using and Foundry does not provide a way to link the library during the compilation step of the tests.Tested
Related issues