Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter to set the block gas limit #1245

Merged
merged 23 commits into from
Nov 9, 2019

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Oct 8, 2019

Description

Added the parameter to the BlockchainParameters contract

Tested

Just added unit test for now.

Other changes

Related issues

Backwards compatibility

Brief explanation of why these changes are/are not backwards compatible.

Copy link
Contributor

@m-chrzan m-chrzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@m-chrzan m-chrzan assigned mrsmkl and unassigned m-chrzan Oct 12, 2019
@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #1245 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1245     +/-   ##
=========================================
- Coverage   74.24%   74.15%   -0.1%     
=========================================
  Files         287      287             
  Lines        7703     7652     -51     
  Branches      666      960    +294     
=========================================
- Hits         5719     5674     -45     
+ Misses       1871     1865      -6     
  Partials      113      113
Flag Coverage Δ
#mobile 74.15% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/web3/contracts.ts 53.06% <0%> (-0.14%) ⬇️
...es/mobile/src/verify/VerificationLoadingScreen.tsx 100% <0%> (ø) ⬆️
.../mobile/src/verify/VerificationEducationScreen.tsx 88.23% <0%> (ø) ⬆️
packages/mobile/src/invite/utils.ts 100% <0%> (ø) ⬆️
packages/mobile/src/components/Carousel.tsx 88.88% <0%> (ø) ⬆️
.../mobile/src/verify/VerificationLearnMoreScreen.tsx 100% <0%> (ø) ⬆️
...bile/src/verify/VerificationInterstitialScreen.tsx 100% <0%> (+9.52%) ⬆️
...ages/mobile/src/verify/VerificationInputScreen.tsx 100% <0%> (+10.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2788391...d084b8c. Read the comment docs.

@asaj asaj self-assigned this Oct 25, 2019
packages/celotool/src/e2e-tests/exit_test.ts Outdated Show resolved Hide resolved
packages/protocol/migrationsConfig.js Outdated Show resolved Hide resolved
packages/protocol/test/governance/blockchainparams.ts Outdated Show resolved Hide resolved
@asaj asaj removed their assignment Oct 30, 2019
@mrsmkl mrsmkl added the automerge Have PR merge automatically when checks pass label Nov 8, 2019
@mrsmkl mrsmkl assigned asaj and unassigned mrsmkl Nov 8, 2019
Copy link
Contributor

@asaj asaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/protocol/test/governance/blockchainparams.ts Outdated Show resolved Hide resolved
@asaj asaj assigned mrsmkl and unassigned asaj Nov 8, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit 471735d into celo-org:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocol SBAT set block gas limit via governance
4 participants