[Mobile] Show Incorrect PIN error in exchange #1345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor change updating the error handling in the exchange. Previously, all exchange errors showed as generic "Exchange failed" error, now this shows "Incorrect pincode" when incorrect pincode is entered
Tested
To test, I modified
getConnectedUnlockedAccount()
to always throw an Incorrect PIN error, and confirmed that the exchange function threw it as well (previously it was catching the error and throwing a generic Exchange failed error)Related issues
Backwards compatibility
Yes