Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Show Incorrect PIN error in exchange #1345

Merged
merged 4 commits into from
Oct 15, 2019
Merged

Conversation

annakaz
Copy link
Contributor

@annakaz annakaz commented Oct 15, 2019

Description

Minor change updating the error handling in the exchange. Previously, all exchange errors showed as generic "Exchange failed" error, now this shows "Incorrect pincode" when incorrect pincode is entered

Tested

To test, I modified getConnectedUnlockedAccount() to always throw an Incorrect PIN error, and confirmed that the exchange function threw it as well (previously it was catching the error and throwing a generic Exchange failed error)

Related issues

Backwards compatibility

Yes

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1345 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
- Coverage   66.44%   66.43%   -0.01%     
==========================================
  Files         264      264              
  Lines        7743     7744       +1     
  Branches      514      514              
==========================================
  Hits         5145     5145              
- Misses       2496     2497       +1     
  Partials      102      102
Flag Coverage Δ
#mobile 66.43% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
packages/mobile/src/exchange/actions.ts 28.15% <0%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d23e79...af9efd1. Read the comment docs.

@annakaz annakaz added the automerge Have PR merge automatically when checks pass label Oct 15, 2019
@annakaz annakaz assigned annakaz and unassigned martinvol and jmrossy Oct 15, 2019
@ashishb ashishb merged commit 772bf91 into master Oct 15, 2019
@ashishb ashishb deleted the annakaz/exchange-fix branch October 15, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
4 participants