[wallet] Refactor leftover thunk to sagas #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1388 +/- ##
=========================================
Coverage ? 65.87%
=========================================
Files ? 271
Lines ? 8048
Branches ? 556
=========================================
Hits ? 5302
Misses ? 2632
Partials ? 114
Continue to review full report at Codecov.
|
jmrossy
reviewed
Oct 18, 2019
martinvol
changed the title
martinvol
force-pushed
the
martinvol/git_rid_thunk
branch
from
142f184
to
b5d7b03
Compare
martinvol
force-pushed
the
martinvol/git_rid_thunk
branch
from
b5d7b03
to
6bd063a
Compare
jmrossy
reviewed
Oct 22, 2019
cmcewen
reviewed
Oct 22, 2019
| try { | ||
| Logger.info(TAG, `Writing pending request to database`) | ||
| const pendingRequestRef = firebase.database().ref(`pendingRequests`) | ||
| return pendingRequestRef.push(paymentInfo) | ||
| pendingRequestRef.push(paymentInfo) |
There was a problem hiding this comment.
It returns a ThenableReference (https://firebase.google.com/docs/reference/js/firebase.database.ThenableReference.html), which still has .then and .catch methods - think you should still yield call this imo
martinvol
force-pushed
the
martinvol/git_rid_thunk
branch
from
eecbe2f
to
9763a05
Compare
jmrossy
approved these changes
Oct 23, 2019
…norepo into martinvol/git_rid_thunk
martinvol
force-pushed
the
martinvol/git_rid_thunk
branch
from
e18ffc7
to
af1dccd
Compare
tkporter
pushed a commit
that referenced
this pull request
Oct 24, 2019
aaronmgdr
added a commit
that referenced
this pull request
Oct 24, 2019
* master: [Wallet] Wallet can switch between hosted and local node (#1419) [Wallet] Prevent error from Avatar when name is missing (#1454) [Wallet] Show splash screen until JS is ready on iOS (#1453) Use new segment api keys used by both iOS and Android (#1452) [Wallet] Don't log all props, which includes i18n (#1445) [Helm] Updated the helm package to deploy the upgraded blockscout version (#1129) Tiny copy change (#1429) [contractkit] SortedOraclesWrapper + tests (#1405) [wallet] Refactor leftover thunk to sagas (#1388) [Wallet] Fix repeated QR code scanning and related navigation issues (#1439) [Wallet] Show the currency values with correct rounding. (#1435) [Wallet] Fix firebase initialization error on iOS after reinstalling the app (#1423) [Wallet] Use exit on iOS since we can't restart like Android (#1424) [Wallet] Update local currency styles and layout (#1325) Reset pincode cache if unlock fails (#1430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes thunk as a dependency and refactored thunks left as sagas.
Tested
Tests were created. Manual test confirm functionality.
Other changes
Related issues
Backwards compatibility
Everything should work as any reducer changed.