[cli] Several changes #1428
Merged
[cli] Several changes #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
=======================================
Coverage 74.15% 74.15%
=======================================
Files 287 287
Lines 7652 7652
Branches 667 667
=======================================
Hits 5674 5674
Misses 1865 1865
Partials 113 113
Continue to review full report at Codecov.
|
nategraf
approved these changes
Oct 24, 2019
asaj
approved these changes
Oct 24, 2019
| * @param signer Address that is authorized to sign the tx as validator | ||
| * @return The Account address | ||
| */ | ||
| validatorSignerToAccount: (signer: Address) => Promise<Address> = proxyCall( |
There was a problem hiding this comment.
Is this consistent with what @nambrot is renaming things? If not, can we aim for consistency?
There was a problem hiding this comment.
i wanted to be on top of nam pr but couldn't...
so when we have that, we'll have to move some methods and have a consistent naming
| * @param address The address of the account | ||
| * @return Returns `true` if account exists. Returns `false` otherwise. | ||
| */ | ||
| isSigner: (address: string) => Promise<boolean> = proxyCall(this.contract.methods.isAuthorized) |
mcortesi
changed the title
yorhodes
approved these changes
Oct 27, 2019
|
|
||
| process.env.NO_SYNCCHECK = 'true' | ||
|
|
||
| testWithGanache('account:authorize cmd', (web3: Web3) => { |
| @@ -1,30 +1,30 @@ | |||
| import { flags } from '@oclif/command' | |||
| import { CLIError } from '@oclif/errors' | |||
mcortesi
requested review from
aaronmgdr,
annakaz,
ashishb,
cmcewen,
jmrossy,
m-chrzan,
nambrot,
timmoreton and
yerdua
as code owners
Also: - Checks on cmds - support use of signer
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
Tested
Related issues
Backwards compatibility
Changes cli affiliate command