Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Performance Optimizations #1449

Merged
merged 5 commits into from
Nov 8, 2019
Merged

Two Performance Optimizations #1449

merged 5 commits into from
Nov 8, 2019

Conversation

aaronmgdr
Copy link
Member

Description

  • Downsize a large image
  • Avoid Animating rising coins on jobs page if we know its a low end device. instead render them statically

Backwards compatibility

yes

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #1449 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1449    +/-   ##
========================================
  Coverage   74.15%   74.15%            
========================================
  Files         287      287            
  Lines        7652     7652            
  Branches      667      960   +293     
========================================
  Hits         5674     5674            
  Misses       1865     1865            
  Partials      113      113
Flag Coverage Δ
#mobile 74.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a1ada...f45433f. Read the comment docs.

@cmcewen cmcewen assigned aaronmgdr and unassigned cmcewen Oct 30, 2019
@aaronmgdr aaronmgdr added the automerge Have PR merge automatically when checks pass label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants