Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test of validator ordering #1472

Merged
merged 22 commits into from
Oct 29, 2019
Merged

E2E test of validator ordering #1472

merged 22 commits into from
Oct 29, 2019

Conversation

cmcewen
Copy link
Contributor

@cmcewen cmcewen commented Oct 24, 2019

Description

With the new round robin shuffle, we want to ensure that we have proper validator ordering and block distribution

Tested

This is a test

Related changes

Depends on: #1464

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@111c353). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1472   +/-   ##
=========================================
  Coverage          ?   73.73%           
=========================================
  Files             ?      277           
  Lines             ?     7418           
  Branches          ?      660           
=========================================
  Hits              ?     5470           
  Misses            ?     1836           
  Partials          ?      112
Flag Coverage Δ
#mobile 73.73% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 111c353...a4b6f71. Read the comment docs.

Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up! It was really helpful in finding the issues with the shuffle change.

I've left a couple of comments, and we should probably merge this after #1464

packages/celotool/src/e2e-tests/validator_order_tests.ts Outdated Show resolved Hide resolved
packages/celotool/src/e2e-tests/validator_order_tests.ts Outdated Show resolved Hide resolved
packages/celotool/src/e2e-tests/validator_order_tests.ts Outdated Show resolved Hide resolved
@nategraf nategraf merged commit 75e7aa7 into master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants