Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Celotool] Integration with truffle blockscout plugin #1540

Merged

Conversation

jcortejoso
Copy link
Member

Description

Added new command bin/celotooljs.sh deploy initial verify-contracts -e berlintestnet001 --all contracts-- or bin/celotooljs.sh deploy initial verify-contracts -e berlintestnet001 --contract RegistryProxy to verify the deployed contracts in the online blockscout for that environment. The contract abis have to be available at packages/protocol/build/<network_name>

Tested

Used the command to validate the contracts in a testnet just after deploying the contracts.

Related issues

Backwards compatibility

No compatibility problems

@jcortejoso jcortejoso force-pushed the feature/intregate_truffle_blockscout_plugin branch from 93f7d07 to d3b892d Compare October 30, 2019 16:03
@jcortejoso jcortejoso force-pushed the feature/intregate_truffle_blockscout_plugin branch from d3b892d to f1a0a16 Compare October 30, 2019 16:17
Copy link
Contributor

@asaj asaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding, what exactly does it mean for a contract to be "verified" in this case?

packages/protocol/truffle-config.js Show resolved Hide resolved
@asaj asaj assigned jcortejoso and unassigned asaj and m-chrzan Nov 6, 2019
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #1540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1540    +/-   ##
=======================================
  Coverage    74.2%   74.2%            
=======================================
  Files         278     278            
  Lines        7653    7653            
  Branches      956     672   -284     
=======================================
  Hits         5679    5679            
  Misses       1857    1857            
  Partials      117     117
Flag Coverage Δ
#mobile 74.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb3400...c56089a. Read the comment docs.

Copy link
Contributor

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timmoreton timmoreton added the Priority: P0 Blocker label Nov 20, 2019
@nambrot nambrot added betanet-blocker and removed Priority: P0 Blocker labels Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developers SBAT register the protocol contracts source code and ABIs in Blockscout easily
7 participants