[verifier] Upgrade to RN 61 #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if I should change for Like in the app's manifest. |
Codecov Report
@@ Coverage Diff @@
## master #1572 +/- ##
=======================================
Coverage 73.85% 73.85%
=======================================
Files 283 283
Lines 7535 7535
Branches 661 661
=======================================
Hits 5565 5565
Misses 1858 1858
Partials 112 112
Continue to review full report at Codecov.
|
…elo-monorepo into martinvol/verifier_upgrade_RN
martinvol
changed the title
…elo-monorepo into martinvol/verifier_upgrade_RN
…elo-monorepo into martinvol/verifier_upgrade_RN
martinvol
commented
Nov 5, 2019
| @@ -87,7 +87,7 @@ class HomeScreen extends React.Component<Props, State> { | |||
|
|
|||
| async componentDidMount() { | |||
| try { | |||
| NetInfo.addEventListener('connectionChange', this.handleNetworkStatusChange) | |||
| NetInfo.addEventListener(this.handleNetworkStatusChange) | |||
There was a problem hiding this comment.
API changed and I was getting a warning
martinvol
changed the title
…elo-monorepo into martinvol/verifier_upgrade_RN
aaronmgdr
added a commit
that referenced
this pull request
Dec 5, 2019
* master: (73 commits) Fix Ethstats Image reference (#1577) EU Cookies Behavior Change (#1447) [verifier] Upgrade to RN 61 (#1572) [Wallet] Update link styles and Implement VerificationEducationScreen (#1565) [wallet] Added native phone picker (#1310) [Wallet] Set up new verification screen skeletons (#1563) Bump e2e test migrate numbers where needed (#1567) [Wallet] Create new carousel component (#1555) [Wallet] Protect Backup Key and Safeguards with PIN (#1556) Increase ganache gas limit (#1569) Re-work locked gold requirements for validators and groups (#1474) Fix e2e on CI (#1537) Allow a specified address to disable/enable the Exchange (#1467) Avoid re-encrypting key files with yarn keys:encrypt command (#1560) Support protocol hotfixing (#613) Point e2e tests back (#1562) Refactor to Accounts.sol (#1392) Add selectIssuers Transaction (#1327) [Wallet] Get React Native Hot Reloading Working (#1551) Unify to prefix messages for signing (#1473) ...
This was referenced Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verifier app hadn't been migrated to RN 61 and didn't build. So far it builds but yarn can't find 'react-native'
Tested
Other changes
Related issues
Backwards compatibility