[Wallet] Implement remaning UI for new verification flow #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use updated RN Geth to support hot reloading
…component Clean up related fonts and styles Implement VerificationEducationScreen
Implement skip modal in verification education screen Implement most of verification loading screen Remove unused dropdown modal package
jmrossy
requested review from
jeanregisser,
martinvol,
cmcewen,
i1skn and
annakaz
cmcewen
reviewed
Nov 5, 2019
| @@ -182,12 +182,12 @@ export function messageContainsAttestationCode(message: string) { | |||
|
|
|||
| export function extractAttestationCodeFromMessage(message: string) { | |||
There was a problem hiding this comment.
i feel that we are a little inconsistent with throwing vs nulls - wdyt?
There was a problem hiding this comment.
Agreed. I'm generally in favor of exceptions but nulls were helpful here. Hbu WDYT?
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
==========================================
+ Coverage 74.16% 74.24% +0.08%
==========================================
Files 287 287
Lines 7651 7703 +52
Branches 666 959 +293
==========================================
+ Hits 5674 5719 +45
- Misses 1864 1871 +7
Partials 113 113
Continue to review full report at Codecov.
|
jeanregisser
approved these changes
Nov 8, 2019
| <View style={styles.modalContainer}> | ||
| <View style={styles.modalTimerContainer}> | ||
| <LoadingSpinner /> | ||
| <Text style={fontStyles.body}>{'0:49'}</Text> |
There was a problem hiding this comment.
I assume the real value will be added in the next PR?
There was a problem hiding this comment.
Yes, already done in my latest
jmrossy
force-pushed
the
rossy/wa-ver-input
branch
from
7f112b3
to
90675a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still TODO: Tie the screens into the verification saga. Will do that in the next PR
Tested
Relevant screens tested locally on Android
still TODO test iOS, will do after done verification implementation
Related issues
Backwards compatibility
Yes