Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow validator groups to update their commission #1624

Merged
merged 11 commits into from
Nov 9, 2019
Merged

Allow validator groups to update their commission #1624

merged 11 commits into from
Nov 9, 2019

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Nov 7, 2019

Description

This PR adds a function to allow validator groups to update their commission, as well as a corresponding command in celocli.

Tested

Contract and contractkit unit tests.

Other changes

  • Remove out of date CLI example

Related issues

Backwards compatibility

Technically yes, though the smart contract was changed.

@codecov
Copy link

codecov bot commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #1624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1624    +/-   ##
========================================
  Coverage   74.23%   74.23%            
========================================
  Files         287      287            
  Lines        7704     7704            
  Branches      667      960   +293     
========================================
  Hits         5719     5719            
  Misses       1871     1871            
  Partials      114      114
Flag Coverage Δ
#mobile 74.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda5aaa...896147a. Read the comment docs.

nategraf
nategraf approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/contractkit/src/wrappers/Validators.test.ts Outdated Show resolved Hide resolved
packages/protocol/contracts/governance/Validators.sol Outdated Show resolved Hide resolved
@nategraf nategraf assigned asaj and unassigned nategraf Nov 7, 2019
@mcortesi mcortesi removed their assignment Nov 8, 2019
@asaj asaj added the automerge Have PR merge automatically when checks pass label Nov 9, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit 930bf31 into master Nov 9, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the asaj/commission branch November 9, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcortesi mcortesi mcortesi approved these changes

@nategraf nategraf nategraf approved these changes

@m-chrzan m-chrzan Awaiting requested review from m-chrzan

Assignees

@asaj asaj

Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users should be able to set and query the commission rate on groups
4 participants
@asaj @mcortesi @nategraf @celo-ci-bot-user