Fix support for validator key rotation, add end-to-end test #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 18, 2019 17:44
nambrot
approved these changes
Nov 14, 2019
| ) { | ||
| const msg = new Buffer('dummy_msg_data') | ||
| const data = '0x' + msg.toString('hex') | ||
| // Note: Eth.sign typing displays incorrect parameter order |
There was a problem hiding this comment.
This note probably should be elsewhere now?
There was a problem hiding this comment.
Yeah, utils/address seems like a better place
| // Note: Eth.sign typing displays incorrect parameter order | ||
| const sig = await signFn(data, signer) | ||
|
|
||
| const rawsig = ethjsutil.fromRpcSig(sig) |
There was a problem hiding this comment.
Optional Nit: Didn't know about fromRpcSig!! Could we streamline either that or our implementation (from below =parseSignature) here?
jmrossy
reviewed
Nov 15, 2019
| export const privateKeyToPublicKey = (privateKey: string) => { | ||
| return '0x' + privateToPublic(Buffer.from(privateKey.slice(2), 'hex')).toString('hex') | ||
| export const publicKeyToAddress = (publicKey: string) => { | ||
| return toChecksumAddress( |
There was a problem hiding this comment.
signatureUtils has this functionality, suggest he use that.
| ) { | ||
| const msg = new Buffer('dummy_msg_data') | ||
| const data = '0x' + msg.toString('hex') | ||
| // Note: Eth.sign typing displays incorrect parameter order |
There was a problem hiding this comment.
Yeah, utils/address seems like a better place
packages/utils/src/signatureUtils.ts
Outdated
| return '0x' + pubKey.toString('hex') | ||
| } | ||
|
|
||
| export function eqAddress(a: Address, b: Address) { |
There was a problem hiding this comment.
Must have been a merge conflict? This was supposed to move to address.ts
added 2 commits
November 15, 2019 11:24
added 3 commits
November 15, 2019 13:25
This was referenced Sep 22, 2022
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes support for validator key rotation, and tests it in the end-to-end governance tests.
Tested
Other changes
publicKeysDatalogic to split out the various components, not store the proof-of-possession.account:authorizeCLI command so that we don't assume account and signing keys are managed by the same node, addaccount:proof-of-possessioncommandaccount:registerAccounts.solAccounts.solprotocolintoutilsRelated issues
Backwards compatibility
Not backwards compatible