[Wallet] Add spinner, timer, and tip text to Verification input screen #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix firebase dbs in google service json files Fix small bug in keyplacer script
…rame Fix missing e164Number on user self avatar Update related snapshots
Improve code organization of input screen components
Codecov Report
@@ Coverage Diff @@
## master #1656 +/- ##
==========================================
+ Coverage 74.29% 74.38% +0.08%
==========================================
Files 278 279 +1
Lines 7540 7565 +25
Branches 944 662 -282
==========================================
+ Hits 5602 5627 +25
+ Misses 1825 1824 -1
- Partials 113 114 +1
Continue to review full report at Codecov.
|
jeanregisser
approved these changes
Nov 12, 2019
| style={styles.codeInput} | ||
| /> | ||
| {isCodeSubmitting && ( | ||
| <ActivityIndicator size="small" color={colors.celoGreen} style={styles.codeInputSpinner} /> |
There was a problem hiding this comment.
Don't we want our custom activity indicator everywhere now?
Comment on lines
+101
to
+102
| this.keyboardDidShowListener = Keyboard.addListener('keyboardDidShow', this.onKeyboardShow) | ||
| this.keyboardDidHideListener = Keyboard.addListener('keyboardDidHide', this.onKeyboardHide) |
There was a problem hiding this comment.
If you end up needing <KeyboardSpacer /> on this screen for iOS, it has a onToggle prop that could simplify this a little.
There was a problem hiding this comment.
Cool, I'll test iOS today and see if that's needed/helpful!
aaronmgdr
added a commit
that referenced
this pull request
Nov 14, 2019
* master: (56 commits) Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585) [Wallet] Add more local currencies (#1698) Switch to correct cluster when fauceting (#1687) [Wallet] Use the country of the phone number for determining the default local currency (#1684) [Wallet] Limit QR code scanner to 1 code per second (#1676) Update Dark backgrounds text color (#1677) Remove integration sync test Minor attestation service fixes (#1680) [wallet] Fixed Native phone picker Use native API instead (#1669) Fix token addresses for notification service (#1674) Add golang to setup docs [wallet] Hide invite education copy after invite was redeemed (#1670) [Wallet] Add spinner, timer, and tip text to Verification input screen (#1656) [Wallet] Fix app deprecation check mechanism (#1358) Point end-to-end governance test back to master (#1665) Add EpochRewards smart contract to calculate epoch rewards and payments (#1558) Optimized Attestation view calls and removal of the reveal TX (#1578) Support claim signatures and support Keybase claims (#1575) [Wallet] Add timestamp to top banner messages (#1657) Export geth metrics on VM testnet (#1351) ... # Conflicts: # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested
Did verification and added new tests
Related issues
Backwards compatibility
Yes