Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added helper function to get the list of current validators #1713

Merged
merged 3 commits into from
Nov 15, 2019

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Nov 14, 2019

Description

Added helper function to get the list of current validators. This will make it easier to read the data in Blockscout.

Tested

I guess the governance test could be changed to use this function.

Other changes

Related issues

Backwards compatibility

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #1713 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   74.26%   74.45%   +0.18%     
==========================================
  Files         277      279       +2     
  Lines        7617     7582      -35     
  Branches      669      664       -5     
==========================================
- Hits         5657     5645      -12     
+ Misses       1845     1823      -22     
+ Partials      115      114       -1
Flag Coverage Δ
#mobile 74.45% <ø> (+0.18%) ⬆️
Impacted Files Coverage Δ
packages/mobile/src/web3/selectors.ts 80% <0%> (-3.34%) ⬇️
packages/mobile/src/invite/reducer.ts 58.82% <0%> (ø) ⬆️
packages/mobile/src/backup/BackupPhrase.tsx 80% <0%> (ø) ⬆️
packages/mobile/src/backup/BackupSocial.tsx 84.78% <0%> (ø) ⬆️
packages/mobile/test/schemas.ts 100% <0%> (ø) ⬆️
packages/mobile/src/images/Images.ts 100% <0%> (ø) ⬆️
packages/mobile/src/images/default-avatar.png 100% <0%> (ø)
packages/mobile/src/images/profile.jpg 100% <0%> (ø)
packages/mobile/src/geth/saga.ts 23.8% <0%> (+0.55%) ⬆️
packages/mobile/src/app/saga.ts 59.03% <0%> (+0.7%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1700119...fecac90. Read the comment docs.

@mrsmkl mrsmkl added the automerge Have PR merge automatically when checks pass label Nov 15, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit d0229ce into celo-org:master Nov 15, 2019
aaronmgdr added a commit that referenced this pull request Nov 15, 2019
* master: (81 commits)
  Make styling more consistent in validator quick start and add password prompt to account:unlock (#1731)
  New Version for contractkit (#1727)
  Remove end-to-end attestations test from circle (#1739)
  Added helper function to get the list of current validators (#1713)
  Fix flaky end-to-end transfer, protocol unit tests (#1734)
  Add AccountClaim to Metadata (#1663)
  [Wallet] Set default gradle properties (#1629)
  Update genesis block after adding parent signatures to block header (#1732)
  Removed end-to-end-geth-integration-sync-test job in workflow (#1730)
  Change the event we emit when selecting issuers (#1706)
  [Wallet] Prompt user to restart app when turning off Forno a second time (#1708)
  Check in spanish verification translations (#1726)
  [Wallet] Style fixes on iOS for verification and backup flows (#1718)
  [Wallet] Reset isRedeemingInvite on rehydrate (#1716)
  Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585)
  [Wallet] Add more local currencies (#1698)
  Switch to correct cluster when fauceting (#1687)
  [Wallet] Use the country of the phone number for determining the default local currency (#1684)
  [Wallet] Limit QR code scanner to 1 code per second (#1676)
  Update Dark backgrounds text color (#1677)
  ...

# Conflicts:
#	packages/web/pages/_app.tsx
#	packages/web/src/dev/BuildPage.tsx
#	packages/web/src/dev/Cover.tsx
#	packages/web/src/dev/StackSection.tsx
#	yarn.lock
aaronmgdr added a commit that referenced this pull request Nov 26, 2019
* master: (70 commits)
  Make styling more consistent in validator quick start and add password prompt to account:unlock (#1731)
  New Version for contractkit (#1727)
  Remove end-to-end attestations test from circle (#1739)
  Added helper function to get the list of current validators (#1713)
  Fix flaky end-to-end transfer, protocol unit tests (#1734)
  Add AccountClaim to Metadata (#1663)
  [Wallet] Set default gradle properties (#1629)
  Update genesis block after adding parent signatures to block header (#1732)
  Removed end-to-end-geth-integration-sync-test job in workflow (#1730)
  Change the event we emit when selecting issuers (#1706)
  [Wallet] Prompt user to restart app when turning off Forno a second time (#1708)
  Check in spanish verification translations (#1726)
  [Wallet] Style fixes on iOS for verification and backup flows (#1718)
  [Wallet] Reset isRedeemingInvite on rehydrate (#1716)
  Adjust e2e transfer and governance tests to match new fee distribution and eliminate ProposerFraction (#1585)
  [Wallet] Add more local currencies (#1698)
  Switch to correct cluster when fauceting (#1687)
  [Wallet] Use the country of the phone number for determining the default local currency (#1684)
  [Wallet] Limit QR code scanner to 1 code per second (#1676)
  Update Dark backgrounds text color (#1677)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devs SBAT read the list of current validators easily from some smart contract
3 participants