-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small improvements to various flaky tests #1772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nategraf
approved these changes
Nov 19, 2019
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
=======================================
Coverage 74.2% 74.2%
=======================================
Files 278 278
Lines 7653 7653
Branches 956 672 -284
=======================================
Hits 5679 5679
Misses 1857 1857
Partials 117 117
Continue to review full report at Codecov.
|
asaj
changed the title
Reduce precision in epoch rewards test
Small fixes to various flaky tests
Nov 20, 2019
…o-monorepo into asaj/protocol-flake
asaj
changed the title
Small fixes to various flaky tests
Small improvements to various flaky tests
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you see the should propose in a round robin fashion test failing, this is typically because one of the nodes is not able to successfully propose, and there's a round change. This is why the expected array (the array of validator signers) winds up being different than the first N block miners of the epoch (where N is the length of the array of validator signers). It seems this typically happens to 0x2ffe970257D93eae9d6B134f528b93b262C31030, which happens to be validator4, i.e. the last validator. Because we bring up validators in series, validator4 has not started its consensus engine by the time other nodes start sending it consensus messages. It fails to handle those messages [2] and disconnects, and does not reconnect by the time it needs to propose a new block. When it does, it doesn't have many (or possibly any) peers to send the preprepare to. To improve this flake, we bring up the nodes in parallel. As a further improvement, we wait a couple epochs before we begin testing blocks, so that if nodes did disconnect from each other, they have time to reconnect.