Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elect validators migration, deploy integration #1847

Merged
merged 12 commits into from
Nov 25, 2019

Conversation

asaj
Copy link
Contributor

@asaj asaj commented Nov 24, 2019

Description

This PR fixes the elect validators migration by updating the validators.

Tested

  • Ran modified end-to-end tests with 10 validators

Other changes

  • Remove unused shuffle in elect validators
  • Make Governance owner of Accounts, EpochRewards
  • Don't override reserve balance in end-to-end tests

@asaj asaj requested a review from m-chrzan as a code owner November 24, 2019 22:57
Copy link
Contributor

@nambrot nambrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

.env.integration Outdated
@@ -1,6 +1,6 @@
ENV_TYPE="integration"

GETH_VERBOSITY=3
GETH_VERBOSITY=4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move back to 3?

@@ -91,7 +91,7 @@ export const privateKeyToStrippedAddress = (privateKey: string) =>

const validatorZeroBalance = fetchEnvOrFallback(
envVar.VALIDATOR_ZERO_GENESIS_BALANCE,
'100010011000000000000000000'
'103010030000000000000000000'
) // 100,010,011 CG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still valid then?

@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #1847 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1847   +/-   ##
======================================
  Coverage    74.2%   74.2%           
======================================
  Files         278     278           
  Lines        7653    7653           
  Branches      956     956           
======================================
  Hits         5679    5679           
  Misses       1857    1857           
  Partials      117     117
Flag Coverage Δ
#mobile 74.2% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4efd0b...27e4ccc. Read the comment docs.

@asaj asaj requested a review from yerdua as a code owner November 25, 2019 00:30
@asaj asaj added the automerge Have PR merge automatically when checks pass label Nov 25, 2019
@celo-ci-bot-user celo-ci-bot-user merged commit cc70435 into master Nov 25, 2019
@celo-ci-bot-user celo-ci-bot-user deleted the timmoreton/integration-fun branch November 25, 2019 01:09
aaronmgdr added a commit that referenced this pull request Nov 26, 2019
* master: (61 commits)
  [Wallet] Handle `/v/<code` deep links for phone verifications (#1776)
  Patch tslint auto fix for macOS Catalina until tslint#6.x is out (#1802)
  Fix typos (#1855)
  Update documentation sidebar (#1861)
  [Wallet] Update forno dev documentation (#1818)
  [Docs] Correct typo
  Validator UX docs for baklava network (#1688) (#1849)
  Various improvements to the CLI, allow voters to revote for a group (#1840)
  Serialize to hex string (#1848)
  Update faucet to pull from the reserve when possible (#1844)
  Fix elect validators migration, deploy integration (#1847)
  Configurable genesis balances (#1838)
  Deploy new version of Celostats and minnor change from celo-blockchain (#1714)
  Make default node URL consistent in celocli (#1805)
  Onboarding feedback (#1811)
  return at least true, when the function is returning bool (#1825)
  Minor Contractkit changes (#1819)
  Point end-to-end tests back to master (#1824)
  Update migration config to correct protocol parameters (#1822)
  Update with new istanbul lookback window size flag (#1820)
  ...

# Conflicts:
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants