Baklava docs improvements #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1854 +/- ##
=======================================
Coverage 74.2% 74.2%
=======================================
Files 278 278
Lines 7653 7653
Branches 956 672 -284
=======================================
Hits 5679 5679
Misses 1857 1857
Partials 117 117
Continue to review full report at Codecov.
|
This was referenced Nov 26, 2019
…on to env variables for clarity
…baklava # Conflicts: # scripts/run-docker-validator-network.sh
make run docker validator network also run on mac
…into fix/baklava-doc-ux
…into fix/baklava-doc-ux
asaj
reviewed
Nov 26, 2019
nambrot
approved these changes
Nov 26, 2019
aaronmgdr
added a commit
that referenced
this pull request
Nov 27, 2019
…into aaronmgdr/build4 * 'aaronmgdr/build4' of github.com:celo-org/celo-monorepo: Dedicated signing of attestation messages (#1913) Allow BLS info to be passed to validator:register without 0x prefix (#1919) Use cert manager instead of lego for k8s SSL certificates (#1924) Fix protocol tests (#1835) Fix bug in LockedGold.relock wrapper (#1915) Add account:show command (#1916) Add warning about misusing pumba (#1857) Baklava docs improvements (#1854) Negate reversed conditional in faucet command (#1863)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies some improvements and address comments
Tested
Other changes
Related issues
v2 of #1688
Backwards compatibility